Support building GeoServer with Maven 3

-------- Original Message --------
Subject: Re: [Geoserver-devel] [ExternalEmail] Re: [Geotools-devel] Proposal to update to Maven 3
Date: Thu, 30 Jun 2011 10:21:50 +0800
From: Ben Caradoc-Davies
To: Justin Deoliveira
CC: geoserver-devel@lists.sourceforge.net, Andrea Aime

Justin,

with your patch, maven 3 build has a unit test failure in ows:
testHandleServiceExceptionCauses(org.geoserver.ows.DefaultServiceExceptionHandlerTest)

-------------------------------------------------------------------------------
Test set: org.geoserver.ows.DefaultServiceExceptionHandlerTest
-------------------------------------------------------------------------------
Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.274
sec <<< FAILURE!
testHandleServiceExceptionCauses(org.geoserver.ows.DefaultServiceExceptionHandlerTest)
Time elapsed: 0.223 sec <<< FAILURE!
junit.framework.AssertionFailedError
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertTrue(Assert.java:27)
at
org.geoserver.ows.DefaultServiceExceptionHandlerTest.testHandleServiceExceptionCauses(DefaultServiceExceptionHandlerTest.java:102)

Kind regards,
Ben.

On 29/06/11 13:20, Justin Deoliveira wrote:
> Yeah, the geoserver build uses a custom plugin to copy over a data directory into the webapp. Its pretty outdated as it seems. A full blown plug-in is not really need for that, and actually it just complicates the build. Some inline ant with the antrun plugin in the web/app pom should do the same and be easier to maintain. So I attached a patch to GEOS-4652 that does just that.
>
> With that and a few other minor tweaks I was able to build geoserver with maven 3. However I did not not run with tests, getting late here So if the other devs could give the patch a spin that would be great. Regardless it should be a decent starting point.
>
> -Justin
>
>

I'm trying to get a full build to work.

I had to make two more fixes:
(1) extension/validation has the wrong parent pom (should be extension not geoserver)
(2) ows DefaultServiceExceptionHandlerTest.testHandleServiceExceptionCauses failure is caused by the exception text being pretty-printed. This is easily fixed by normalising the whitespace. But why does Maven 3 cause this to fail? Everything else is the same? Classloader changes?

Maven 3 has many failures in main. Eclipse passes. Here is an example:

-------------------------------------------------------------------------------
Test set: org.geoserver.security.impl.SecureCatalogIntegrationTest
-------------------------------------------------------------------------------
Tests run: 3, Failures: 0, Errors: 3, Skipped: 0, Time elapsed: 0.134 sec <<< FA
ILURE!
testFullAccess(org.geoserver.security.impl.SecureCatalogIntegrationTest) Time e
lapsed: 0.075 sec <<< ERROR!
java.lang.AbstractMethodError: org.apache.xerces.dom.DocumentImpl.getXmlStandalo
ne()Z
at com.sun.org.apache.xalan.internal.xsltc.trax.DOM2TO.setDocumentInfo(D
OM2TO.java:373)
at com.sun.org.apache.xalan.internal.xsltc.trax.DOM2TO.parse(DOM2TO.java
:127)
at com.sun.org.apache.xalan.internal.xsltc.trax.DOM2TO.parse(DOM2TO.java
:94)
at com.sun.org.apache.xalan.internal.xsltc.trax.TransformerImpl.transfor
mIdentity(TransformerImpl.java:661)
at com.sun.org.apache.xalan.internal.xsltc.trax.TransformerImpl.transfor
m(TransformerImpl.java:707)
at com.sun.org.apache.xalan.internal.xsltc.trax.TransformerImpl.transfor
m(TransformerImpl.java:313)
at org.geoserver.data.CatalogWriter.write(CatalogWriter.java:253)

The failure in main is fixed by adding a xalan test dependency.

And the JRE internal xalan is almost certainly what was causing the changed behaviour in ows DefaultServiceExceptionHandlerTest.testHandleServiceExceptionCauses.

Andrea, can you explain what is going on? Does this changed behaviour have any implications for deployments if we no longer ship xalan?

Looks like geoserver has too many xercesImpl in the top-level dependencyManagement. I'll try cutting back to one and syncing with GT. (creds to aaime for suggesting cutting something out was the likely solution)

Build fails in WMS unless GEOS-4689 patch is applied.

Success! The attached patch GEOS-4652.complete-including-xercesImpl-and-wms.patch allows GeoServer to be built with Maven 3. It includes the patch for GEOS-4689 and my original GEOS-4685 xercesImpl fixes (although we should use Ian's version which does more). This version includes all of Justin's original patch. It also fixes an ows whitespace problem that might no longer be an issue with xercesImpl 2.7.1, but is better code.

Andrea, assembly:attached works as well. The war.zip is 50 MB, so we might be getting a few more included dependencies. (IIRC with m2 it is about 46 MB.)

GEOS-4652.complete.patch contains just the pom and ows changes, now that Ian has committed the xercesImpl (GEOS-4685) changes. This patch is a superset of GEOS-4652.patch.

Building with Maven 3 also requires the GEOS-4689 patch, which should be in a separate commit.

+1

Committed to trunk in r16218.

Reopening in order to reassign to 2.1-beta2 release

Switching all issues that have been in "resolved" state for more than one month without further comments to "closed" status