GeoServer
  1. GeoServer
  2. GEOS-4595

Add ISO 19115:2003 as a type option in Layer Metadata URL

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.1.0
    • Fix Version/s: 2.1.2
    • Component/s: None
    • Labels:
      None
    • Number of attachments :
      1

      Description

      In Layer Metadata URL we only have FGDC and TC211 as types. With INSPIRE many people want to select 19115:2003. We should make it a drop down option.

        Activity

        Hide
        John Hudson added a comment -

        simple addition of the ISO option in the select box.

        Show
        John Hudson added a comment - simple addition of the ISO option in the select box.
        Hide
        Gabriel Roldan added a comment -

        patch applied at r16367 for 2.1.x and r16368 on trunk

        Show
        Gabriel Roldan added a comment - patch applied at r16367 for 2.1.x and r16368 on trunk
        Hide
        Bart van den Eijnden added a comment -

        Gabriel, there is an error in the current implementation. The value for the type attribute should be "ISO19115:2003" (no space) and not "ISO 19115:2003"

        SystemID: http://localhost:8080/geoserver/wms?service=WMS&request=GetCapabilities
        Engine name: Xerces
        Severity: error
        Description: cvc-datatype-valid.1.2.1: 'ISO 19115:2003' is not a valid value for 'NMTOKEN'.
        Start location: 4872:44
        URL: http://www.w3.org/TR/xmlschema-2/#cvc-datatype-valid

        Show
        Bart van den Eijnden added a comment - Gabriel, there is an error in the current implementation. The value for the type attribute should be "ISO19115:2003" (no space) and not "ISO 19115:2003" SystemID: http://localhost:8080/geoserver/wms?service=WMS&request=GetCapabilities Engine name: Xerces Severity: error Description: cvc-datatype-valid.1.2.1: 'ISO 19115:2003' is not a valid value for 'NMTOKEN'. Start location: 4872:44 URL: http://www.w3.org/TR/xmlschema-2/#cvc-datatype-valid
        Hide
        Gabriel Roldan added a comment -

        fixed at r16379 on 2.1.x and r16380 on trunk.

        Show
        Gabriel Roldan added a comment - fixed at r16379 on 2.1.x and r16380 on trunk.
        Hide
        Gabriel Roldan added a comment -

        Setting MetadataURL type to something else than WMS 1.1 supports (FGDC or TC211), break the WMS 1.1 GetCapabilities in GeoServer (invalid XML produced). So people can never set up an INSPIRE VIew Service and have the WMS 1.1 work as well as a basic WMS.

        Show
        Gabriel Roldan added a comment - Setting MetadataURL type to something else than WMS 1.1 supports (FGDC or TC211), break the WMS 1.1 GetCapabilities in GeoServer (invalid XML produced). So people can never set up an INSPIRE VIew Service and have the WMS 1.1 work as well as a basic WMS.
        Hide
        Gabriel Roldan added a comment -

        So in order to output valid WMS 1.1.1 caps documents the idea would be to skip any non FGDC/TC211 metadata url (only for 1.1.1), correct?

        Show
        Gabriel Roldan added a comment - So in order to output valid WMS 1.1.1 caps documents the idea would be to skip any non FGDC/TC211 metadata url (only for 1.1.1), correct?
        Hide
        Andrea Aime added a comment -

        Allow me to understand this one better: is WMS 1.1 broken now?

        On the thread we had Friday about releasing 2.1.2 Justin said the following:

        "That will work... however we are currently working on some inspire related fixes for wms 1.3.0 and the client would like an official release of it relatively soon. The deadline is Oct 21st... so +1 on a release now/Monday if people don't mind a new release popping up a few weeks later.

        The fixes in question do make some config changes so I do like the idea of doing a release now, then committing those changes and letting them sit for a couple of weeks before putting them out in a release"

        And we agreed to make a 2.1.2 now, without the inspire changes, and make another at the end of the month. However I see this change has been committed to 2.1.x yesterday, ignoring the above, so I'm worried about the current status of WMS 1.1
        The CITE tests did run fine tonight though, would one get an invalid WMS 1.1 only with particular settings?

        Regardless, please keep an eye on the mailing list and avoid committing on a rush on the stable series just before a release unless you're 100% sure of the results. I committed a couple of patches on Sunday but they had been reviewed by someone else.

        Show
        Andrea Aime added a comment - Allow me to understand this one better: is WMS 1.1 broken now? On the thread we had Friday about releasing 2.1.2 Justin said the following: "That will work... however we are currently working on some inspire related fixes for wms 1.3.0 and the client would like an official release of it relatively soon. The deadline is Oct 21st... so +1 on a release now/Monday if people don't mind a new release popping up a few weeks later. The fixes in question do make some config changes so I do like the idea of doing a release now, then committing those changes and letting them sit for a couple of weeks before putting them out in a release" And we agreed to make a 2.1.2 now, without the inspire changes, and make another at the end of the month. However I see this change has been committed to 2.1.x yesterday, ignoring the above, so I'm worried about the current status of WMS 1.1 The CITE tests did run fine tonight though, would one get an invalid WMS 1.1 only with particular settings? Regardless, please keep an eye on the mailing list and avoid committing on a rush on the stable series just before a release unless you're 100% sure of the results. I committed a couple of patches on Sunday but they had been reviewed by someone else.
        Hide
        Bart van den Eijnden added a comment -

        Hey Andrea, it's only broken if people use a MetadataURL type that is not defined by WMS 1.1 (FGDC or TC211). The same applies if people use "other" see http://jira.codehaus.org/browse/GEOS-4673 so this is not anything that was changed by the INSPIRE work.

        Show
        Bart van den Eijnden added a comment - Hey Andrea, it's only broken if people use a MetadataURL type that is not defined by WMS 1.1 (FGDC or TC211). The same applies if people use "other" see http://jira.codehaus.org/browse/GEOS-4673 so this is not anything that was changed by the INSPIRE work.
        Hide
        Andrea Aime added a comment -

        Good to know, thanks Bart

        Show
        Andrea Aime added a comment - Good to know, thanks Bart
        Hide
        Gabriel Roldan added a comment -

        In addition to Bart's explanation, I think I didn't commit anything that makes any config change. In fact, for the one issue that I've assigned that needs a config change I still have to write the appropriate GSIP, but am just waiting to figure out the backwards compatibility approach before doing so.

        Show
        Gabriel Roldan added a comment - In addition to Bart's explanation, I think I didn't commit anything that makes any config change. In fact, for the one issue that I've assigned that needs a config change I still have to write the appropriate GSIP, but am just waiting to figure out the backwards compatibility approach before doing so.
        Hide
        Gabriel Roldan added a comment -

        Bart, I'm closing this one so we can continue on the valid 1.1.1 getcaps work at GEOS-4673 after 2.1.2. The patch is rather simple but in any case it'd be better not to push anything else just before that.

        Show
        Gabriel Roldan added a comment - Bart, I'm closing this one so we can continue on the valid 1.1.1 getcaps work at GEOS-4673 after 2.1.2. The patch is rather simple but in any case it'd be better not to push anything else just before that.

          People

          • Assignee:
            Gabriel Roldan
            Reporter:
            Chris Holmes
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: