Details
-
Type:
Improvement
-
Status:
Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 2.1.0
-
Fix Version/s: 2.1.1
-
Component/s: Google Earth KML Output, WMS
-
Labels:None
-
Patch Submitted:Yes
Description
URLMangler support didn't make it into KML Network Links (or GeoRSS, as it turns out).
I've attached a patch against 2.1.x that replaces all the manual URL-assembling that I can find in the KML code with calls to ResponseUtils.buildURL() (which uses URLMangler), and deprecates the use of WMSRequests.getBaseUrl().
I also expanded buildURL() to handle null values in KVP parameters since they seemed to pop up in a number of places. Now, {"key1":null, "key2":"val"} resolves to "...&key1=&key2=val".
In my limited testing the patch works as expected, and the test suite passes. If someone can have a quick once-over and suggest whether the approach is right, and whether new tests are required, that'd be great.
Patch applied on 2.1.x and trunk. Thanks for the contribution!