GeoServer

Enhance Excel WFS output plugin, including adding support for Excel 2007 workbooks

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 2.2-beta1
  • Component/s: Excel
  • Labels:
    None
  • Testcase included:
    yes
  • Patch Submitted:
    Yes
  • Number of attachments :
    1

Description

Attached is a patch that enhances the current Excel WFS output plugin. Better formatting and data truncation handling are added for Excel 97 files. Support for OOXML Excel 2007 files is also added (output format "excel2007").

Excel 2007 workbooks can handle up to 1,048,576 rows and 16,384 columns, so they are ideal for downloading large datasets. Unfortunately these large POI XML workbook objects also take up a huge amount of memory, so a workaround published by one of the POI authors is implemented for Excel 2007. If POI's memory usage improves in the future, the overriding Excel 2007 write method can be removed and the Excel 2007 output will use the standard POI ss usermodel.

Patch included updated test cases and also upgrades POI to version 3.7.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Justin Deoliveira added a comment -

Hi Shane, nice work on the contribution. The changes look great. Not sure that module really has a designated maintainer so I don't think we need to wait on a review for anyone.

@Andrea: what do you think?

@Shane: would you be interested in maintaining the module?

Show
Justin Deoliveira added a comment - Hi Shane, nice work on the contribution. The changes look great. Not sure that module really has a designated maintainer so I don't think we need to wait on a review for anyone. @Andrea: what do you think? @Shane: would you be interested in maintaining the module?
Hide
Permalink
Andrea Aime added a comment -

Yeah, it would be nice to have a stable maintainer for the module. Was it contributed by David? Anyways, someone from OpenGeo that gradually contributed less and less to the project and in fact the module is now basically unmaintained, the only reason for not kicking it back into community space is that it appears to be working fine. So if Shane wants to maintain it, that would be great.

Show
Andrea Aime added a comment - Yeah, it would be nice to have a stable maintainer for the module. Was it contributed by David? Anyways, someone from OpenGeo that gradually contributed less and less to the project and in fact the module is now basically unmaintained, the only reason for not kicking it back into community space is that it appears to be working fine. So if Shane wants to maintain it, that would be great.
Hide
Permalink
Shane StClair added a comment -

Sure, I'd be happy to maintain the plugin. The original author was Sebastian Benthall, but it looks like he's plenty busy with GeoNode. I don't imagine that it will need updates very often...I'll just keep an eye on POI and roll in performance upgrades as new versions come out.

Show
Shane StClair added a comment - Sure, I'd be happy to maintain the plugin. The original author was Sebastian Benthall, but it looks like he's plenty busy with GeoNode. I don't imagine that it will need updates very often...I'll just keep an eye on POI and roll in performance upgrades as new versions come out.
Hide
Permalink
Andrea Aime added a comment -

Shane, if you want to become maintainer you have to ask on the developer list, present yourself, explain people there what you want to do, and ask to become a developer

Show
Andrea Aime added a comment - Shane, if you want to become maintainer you have to ask on the developer list, present yourself, explain people there what you want to do, and ask to become a developer
Hide
Permalink
Andrea Aime added a comment -

Hi Shane, haven't heard anything since. Did you manage to get commit access?

Show
Andrea Aime added a comment - Hi Shane, haven't heard anything since. Did you manage to get commit access?
Hide
Permalink
Shane StClair added a comment -

Hi Andrea, sorry, yes I think I'm all set. I was holding off on committing because I saw that 2.1-RC5 is in the process of being pushed out, and I didn't want to do my first commit in the middle of that process in case I did something wrong. If you don't think that's an issue, I can check in my changes tomorrow.

Show
Shane StClair added a comment - Hi Andrea, sorry, yes I think I'm all set. I was holding off on committing because I saw that 2.1-RC5 is in the process of being pushed out, and I didn't want to do my first commit in the middle of that process in case I did something wrong. If you don't think that's an issue, I can check in my changes tomorrow.
Hide
Permalink
Shane StClair added a comment -

Ok, changes committed and closing issue. Thanks!

Show
Shane StClair added a comment - Ok, changes committed and closing issue. Thanks!
Hide
Permalink
Shane StClair added a comment -

Changes applied, including upgrade of POI to 3.7 and addition of excel2007 output format support.

Show
Shane StClair added a comment - Changes applied, including upgrade of POI to 3.7 and addition of excel2007 output format support.
Hide
Permalink
Andrea Aime added a comment -

Mass closing all issues that have been in "resolved" state for more than a month without further comments

Show
Andrea Aime added a comment - Mass closing all issues that have been in "resolved" state for more than a month without further comments
Hide
Permalink
Justin Deoliveira added a comment -

Reopening in order to reassign to 2.1-beta2 release

Show
Justin Deoliveira added a comment - Reopening in order to reassign to 2.1-beta2 release
Hide
Permalink
Andrea Aime added a comment -

Switching all issues that have been in "resolved" state for more than one month without further comments to "closed" status

Show
Andrea Aime added a comment - Switching all issues that have been in "resolved" state for more than one month without further comments to "closed" status

People

  • Assignee:
    Shane StClair
    Reporter:
    Shane StClair
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: