GeoServer
  1. GeoServer
  2. GEOS-4421

SpringDelegatingFilter interferes with security

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.1.x
    • Component/s: None
    • Labels:
      None
    • Number of attachments :
      4

      Description

      The filter picks up and applies all security related filters declared in the app-context.
      However those filters need to be applied in a specific order, and should not be used at all when we disable the security subsystem following the instructions at http://docs.geoserver.org/latest/en/user/security/sec_disable.html

      Recommended solution: have the delegating filter look for a marker interface, not just any filter. Something like GeoServerPluginFilter or the like

      1. GEOS-4421.patch
        11 kB
        Andrea Aime
      2. GEOS-4421-a.patch
        13 kB
        Justin Deoliveira
      3. GEOS-4421-a.patch
        26 kB
        Justin Deoliveira
      1. filters.png
        72 kB

        Activity

        Hide
        Andrea Aime added a comment -

        Yep, looks good

        Show
        Andrea Aime added a comment - Yep, looks good
        Hide
        Andrea Aime added a comment -

        Soo... what about committing it? Shall I go ahead? 2.1.x too?

        Show
        Andrea Aime added a comment - Soo... what about committing it? Shall I go ahead? 2.1.x too?
        Hide
        Justin Deoliveira added a comment -

        Sounds good. +1 to committing to 2.1.x as well.

        Show
        Justin Deoliveira added a comment - Sounds good. +1 to committing to 2.1.x as well.
        Hide
        Andrea Aime added a comment -

        Patch applied on 2.1.x and trunk. The dbconfig module build fails for me btw, but I see that on Hudson the tests for community modules are not run anyways, and I checked by reverting the patch that I was getting the same 4 errors.
        One of them is the same reported in GEOS-4562

        Show
        Andrea Aime added a comment - Patch applied on 2.1.x and trunk. The dbconfig module build fails for me btw, but I see that on Hudson the tests for community modules are not run anyways, and I checked by reverting the patch that I was getting the same 4 errors. One of them is the same reported in GEOS-4562
        Hide
        Andrea Aime added a comment -

        Mass transition all resolved issue that did not see any further comment in the last month to closed status

        Show
        Andrea Aime added a comment - Mass transition all resolved issue that did not see any further comment in the last month to closed status

          People

          • Assignee:
            Justin Deoliveira
            Reporter:
            Andrea Aime
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: