GeoServer

ResourcePoolInitializer sets the feature type cache size to 0 regardless of the actual configuration

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.1-RC1
  • Fix Version/s: 2.1-RC2
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    2

Description

This is happening because it's using the index of the property instead of its value:

geoServer.addListener(new ConfigurationListenerAdapter() {
            @Override
            public void handleGlobalChange(GeoServerInfo global, List<String> propertyNames,
                    List<Object> oldValues, List<Object> newValues) {
                int i = propertyNames.indexOf( "featureTypeCacheSize" );
                if (i > -1) {
                    gs.getCatalog().getResourcePool().setFeatureTypeCacheSize(i);
                }
            }
        });

This in turn results the LRUMap to use its default size, which is only 16

  1. Text File
    GEOS-4326.patch
    25/Jan/11 3:44 AM
    4 kB
    Andrea Aime
  2. Text File
    GEOS-4326.patch
    25/Jan/11 3:43 AM
    4 kB
    Andrea Aime

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Andrea Aime added a comment -

Actually debugging shows an exception is thrown during the LRUMap construction, which is eaten away in GeoServerImpl line 154:

for ( ConfigurationListener l : listeners ) {
            try {
                l.handleGlobalChange( geoServer, propertyNames, oldValues, newValues);
            }
            catch( Exception e ) {
                //log this
            }
        }

I guess I'll also add some logging there :-p

Show
Andrea Aime added a comment - Actually debugging shows an exception is thrown during the LRUMap construction, which is eaten away in GeoServerImpl line 154: for ( ConfigurationListener l : listeners ) { try { l.handleGlobalChange( geoServer, propertyNames, oldValues, newValues); } catch ( Exception e ) { //log this } } I guess I'll also add some logging there :-p
Hide
Permalink
Andrea Aime added a comment -

Here is a patch for 2.0.x, checked, the same issue exists on 2.1.x and trunk. Justin, want to quickly review this one?

Show
Andrea Aime added a comment - Here is a patch for 2.0.x, checked, the same issue exists on 2.1.x and trunk. Justin, want to quickly review this one?
Hide
Permalink
Andrea Aime added a comment -

Updated patch to remove an unecessary sysout

Show
Andrea Aime added a comment - Updated patch to remove an unecessary sysout
Hide
Permalink
Justin Deoliveira added a comment -

looks good. +1

Show
Justin Deoliveira added a comment - looks good. +1
Hide
Permalink
Andrea Aime added a comment -

Fixed on 2.1.x and trunk (Feb 6)

Show
Andrea Aime added a comment - Fixed on 2.1.x and trunk (Feb 6)
Hide
Permalink
Andrea Aime added a comment -

Bulk closing all resolved issue that have not gotten any more feedback or comment in the last month

Show
Andrea Aime added a comment - Bulk closing all resolved issue that have not gotten any more feedback or comment in the last month

People

  • Assignee:
    Andrea Aime
    Reporter:
    Andrea Aime
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: