GeoServer

[patch] GeoServer german translation (DE)

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0.2
  • Fix Version/s: 2.1.3, 2.2.x
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    7

Description

some more translation to german is done. still needs some review and some translations are missing

Attachments

  1. Text File
    _de.properties.patch
    16/Jan/11 3:22 PM
    60 kB
    Frank Gasdorf
  2. Text File
    GEOS-4294_5.patch
    16/Jun/11 5:31 AM
    2 kB
    Frank Gasdorf
  5. File
    GeoServerApplication_de.properties
    30/Jan/11 2:53 PM
    8 kB
    Frank Gasdorf
  6. Text File
    gs-4294-web-security_de.patch
    06/Feb/11 12:48 PM
    2 kB
    Frank Gasdorf
  7. Text File
    gs-web-gwc_de.patch
    18/Feb/11 2:32 PM
    3 kB
    Frank Gasdorf

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Astrid Emde added a comment -

Christian Müller offered to do the review.

Show
Astrid Emde added a comment - Christian Müller offered to do the review.
Hide
Permalink
Christian Mueller added a comment -

Astrid, I did a quick check of the file encodings

./core/GeoServerApplication_de.properties: UTF-8 Unicode English text
./demo/GeoServerApplication_de.properties: UTF-8 Unicode English text
./gwc/GeoServerApplication_de.properties: ASCII text
./security/GeoServerApplication_de.properties: UTF-8 Unicode English text, with very long lines
./wcs/GeoServerApplication_de.properties: ISO-8859 text
./wfs/GeoServerApplication_de.properties: ISO-8859 text
./wms/GeoServerApplication_de.properties: ASCII text

Two files are us-ascii, two files are iso-8859.

If I look at your files on a linux box I see lines like

WCSLayerConfig.deleteSelected=Gew�hlte l�schen

Do you have the possibility to save all your files encoded in UTF-8 and upload a new zip file, otherwise we will get problems on different platforms.

Show
Christian Mueller added a comment - Astrid, I did a quick check of the file encodings ./core/GeoServerApplication_de.properties: UTF-8 Unicode English text ./demo/GeoServerApplication_de.properties: UTF-8 Unicode English text ./gwc/GeoServerApplication_de.properties: ASCII text ./security/GeoServerApplication_de.properties: UTF-8 Unicode English text, with very long lines ./wcs/GeoServerApplication_de.properties: ISO-8859 text ./wfs/GeoServerApplication_de.properties: ISO-8859 text ./wms/GeoServerApplication_de.properties: ASCII text Two files are us-ascii, two files are iso-8859. If I look at your files on a linux box I see lines like WCSLayerConfig.deleteSelected=Gew�hlte l�schen Do you have the possibility to save all your files encoded in UTF-8 and upload a new zip file, otherwise we will get problems on different platforms.
Hide
Permalink
Astrid Emde added a comment -

Christian, I saved the files as UTF-8. In my editor the charaters are ok.

Show
Astrid Emde added a comment - Christian, I saved the files as UTF-8. In my editor the charaters are ok.
Hide
Permalink
Astrid Emde added a comment -

Christian,

I changed the encoding to UTF-8.

Show
Astrid Emde added a comment - Christian, I changed the encoding to UTF-8.
Hide
Permalink
Frank Gasdorf added a comment - - edited

Astrid, Christian,

I started reviewing the property files too and created a patch file for easy sharing based on trunk. I attach a partly changed file for the core module. Do you have a chance to work with a patch file and provide new one for the unfinished stuff?

Show
Frank Gasdorf added a comment - - edited Astrid, Christian, I started reviewing the property files too and created a patch file for easy sharing based on trunk. I attach a partly changed file for the core module. Do you have a chance to work with a patch file and provide new one for the unfinished stuff?
Hide
Permalink
Christian Mueller added a comment -

Applying the patch failed

-----------------
patch -p0 < ~/Downloads/web-core-GeoServerApplication_de.patch
(Stripping trailing CRs from patch.)
patching file GeoServerApplication_de.properties
Hunk #1 FAILED at 1.
Hunk #2 FAILED at 115.
2 out of 2 hunks FAILED – saving rejects to file GeoServerApplication_de.properties.rej
-----------------

Can you create a geoserver_translation_de_3.zip including your changes.

At the moment I have problems with admin GUI, German special characters are not displayed correctly.

Btw, who of us will take care of the German translation in the future ?

Show
Christian Mueller added a comment - Applying the patch failed ----------------- patch -p0 < ~/Downloads/web-core-GeoServerApplication_de.patch (Stripping trailing CRs from patch.) patching file GeoServerApplication_de.properties Hunk #1 FAILED at 1. Hunk #2 FAILED at 115. 2 out of 2 hunks FAILED – saving rejects to file GeoServerApplication_de.properties.rej ----------------- Can you create a geoserver_translation_de_3.zip including your changes. At the moment I have problems with admin GUI, German special characters are not displayed correctly. Btw, who of us will take care of the German translation in the future ?
Hide
Permalink
Frank Gasdorf added a comment -

Added a patch for the modules listed below:

  • core
  • demo
  • wms

Hopefully the patch can be applied this time. Checked the patch as well as the frontend in my 2.1-beta instance on win and mac os. All special german chars were displayed fine.

Could someone review the TODO's within! Thanks!

Show
Frank Gasdorf added a comment - Added a patch for the modules listed below:
  • core
  • demo
  • wms
Hopefully the patch can be applied this time. Checked the patch as well as the frontend in my 2.1-beta instance on win and mac os. All special german chars were displayed fine. Could someone review the TODO's within! Thanks!
Hide
Permalink
Christian Mueller added a comment -

The patch works !

I committed the three files on trunk.

About the TODOs. I am not sure if we should translate the JAI settings since there is no official documentation about JAI itself.

There are another 4 files left, are you continuing to work on them.

Show
Christian Mueller added a comment - The patch works ! I committed the three files on trunk. About the TODOs. I am not sure if we should translate the JAI settings since there is no official documentation about JAI itself. There are another 4 files left, are you continuing to work on them.
Hide
Permalink
Frank Gasdorf added a comment - - edited

Yes, I try to finish the others within the next days and attach these to the issue as well.

Show
Frank Gasdorf added a comment - - edited Yes, I try to finish the others within the next days and attach these to the issue as well.
Hide
Permalink
Frank Gasdorf added a comment -

A doc about documentation : GEOS-4323

Show
Frank Gasdorf added a comment - A doc about documentation : GEOS-4323
Hide
Permalink
Frank Gasdorf added a comment -

added web-security german translation properties file. Please REVIEW, especially the Catalog mode descriptions.

Show
Frank Gasdorf added a comment - added web-security german translation properties file. Please REVIEW, especially the Catalog mode descriptions.
Hide
Permalink
Christian Mueller added a comment -

Committed the security translations to trunk, now we can work with patches.
I have seen there are still English Strings in the file ?

Show
Christian Mueller added a comment - Committed the security translations to trunk, now we can work with patches. I have seen there are still English Strings in the file ?
Hide
Permalink
Christian Mueller added a comment -

gs-4294-web-security_de.patch commited to trunk

Show
Christian Mueller added a comment - gs-4294-web-security_de.patch commited to trunk
Hide
Permalink
Frank Gasdorf added a comment -

GeoWebCache German translation property file

Show
Frank Gasdorf added a comment - GeoWebCache German translation property file
Hide
Permalink
Christian Mueller added a comment -

gs-web-gwc_de.patch commited to trunk

Show
Christian Mueller added a comment - gs-web-gwc_de.patch commited to trunk
Hide
Permalink
Christian Mueller added a comment -

Applying
patch -p0 < ~/Downloads/gs-web_de.patch

on trunk gives me

patching file src/web/gwc/src/main/resources/GeoServerApplication_de.properties
Reversed (or previously applied) patch detected! Assume -R? [n]

I aborted the patch. Frank, can you do a fresh check out into a new directory and try to apply the patch ?.

Show
Christian Mueller added a comment - Applying patch -p0 < ~/Downloads/gs-web_de.patch on trunk gives me patching file src/web/gwc/src/main/resources/GeoServerApplication_de.properties Reversed (or previously applied) patch detected! Assume -R? [n] I aborted the patch. Frank, can you do a fresh check out into a new directory and try to apply the patch ?.
Hide
Permalink
Frank Gasdorf added a comment -

Christian,

I checked the patch file and - sorry for that - it was a patch that has been already applied to trunk. I deleted the attachment to avoid confusion ..

Show
Frank Gasdorf added a comment - Christian, I checked the patch file and - sorry for that - it was a patch that has been already applied to trunk. I deleted the attachment to avoid confusion ..
Hide
Permalink
Frank Gasdorf added a comment -

Added patchfile #5 to apply on trunk with some fixed UTF8 issues and a few translations as well

Show
Frank Gasdorf added a comment - Added patchfile #5 to apply on trunk with some fixed UTF8 issues and a few translations as well
Hide
Permalink
Christian Mueller added a comment -

Applying

mcr@l00001:~/gs-trunk> patch -p0 < ~/Downloads/GEOS-4294_5.patch

results in

patching file src/web/wfs/src/main/resources/GeoServerApplication_de.properties
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED – saving rejects to file src/web/wfs/src/main/resources/GeoServerApplication_de.properties.rej
patching file src/web/wcs/src/main/resources/GeoServerApplication_de.properties

Frank, do you test your patches by applying them to a fresh checkout ?

Show
Christian Mueller added a comment - Applying mcr@l00001:~/gs-trunk> patch -p0 < ~/Downloads/GEOS-4294_5.patch results in patching file src/web/wfs/src/main/resources/GeoServerApplication_de.properties Hunk #1 FAILED at 1. 1 out of 1 hunk FAILED – saving rejects to file src/web/wfs/src/main/resources/GeoServerApplication_de.properties.rej patching file src/web/wcs/src/main/resources/GeoServerApplication_de.properties Frank, do you test your patches by applying them to a fresh checkout ?
Hide
Permalink
Frank Gasdorf added a comment -

totally new checkout from trunk and applied the patch GEOS-4294_5.patch successfully:

patch -p0 < ./../GEOS-4294_5.patch
patching file src/web/wfs/src/main/resources/GeoServerApplication_de.properties
patching file src/web/wcs/src/main/resources/GeoServerApplication_de.properties

Show
Frank Gasdorf added a comment - totally new checkout from trunk and applied the patch GEOS-4294_5.patch successfully: patch -p0 < ./../GEOS-4294_5.patch patching file src/web/wfs/src/main/resources/GeoServerApplication_de.properties patching file src/web/wcs/src/main/resources/GeoServerApplication_de.properties
Hide
Permalink
Frank Gasdorf added a comment -

Astrid,
Christian,

I just look at the livd DVD install scripts and the used geoserver version is 2.1.0. Right now the translations were only committed on trunk. So I guess we should port these back to 2.1.x if we do not upgrade to 2.2.0 for the live dvd. Would you agree? Is it also a need to have translations for 2.0.x?

Frank

Show
Frank Gasdorf added a comment - Astrid, Christian, I just look at the livd DVD install scripts and the used geoserver version is 2.1.0. Right now the translations were only committed on trunk. So I guess we should port these back to 2.1.x if we do not upgrade to 2.2.0 for the live dvd. Would you agree? Is it also a need to have translations for 2.0.x? Frank
Hide
Permalink
Christian Mueller added a comment -

Applied the patch successfully.

No translations for 2.0.x, this version is out of maintenance.

For 2.1.x, you can do as you like.

Show
Christian Mueller added a comment - Applied the patch successfully. No translations for 2.0.x, this version is out of maintenance. For 2.1.x, you can do as you like.
Hide
Permalink
Christian Mueller added a comment -

Frank, your request for commit access was on the wrong list. You have to mail to the geoserver-devel list, not to the geotools-devel list.

I am not a PSC member of geotools but I would support this, stop playing ping-pong with patch files.

Show
Christian Mueller added a comment - Frank, your request for commit access was on the wrong list. You have to mail to the geoserver-devel list, not to the geotools-devel list. I am not a PSC member of geotools but I would support this, stop playing ping-pong with patch files.
Hide
Permalink
Christian Mueller added a comment -

Ahhhhhhhh, to much work on too many fronts. I am a PSC member of geotools but not of geoserver. geoserver code is where you need to commit access.

Show
Christian Mueller added a comment - Ahhhhhhhh, to much work on too many fronts. I am a PSC member of geotools but not of geoserver. geoserver code is where you need to commit access.
Hide
Permalink
Frank Gasdorf added a comment -

Don't worry, Andrea Aime already gave me commit access for geoserver

Show
Frank Gasdorf added a comment - Don't worry, Andrea Aime already gave me commit access for geoserver
Hide
Permalink
Christian Mueller added a comment -

Nice, so I can stop watching this issue and leave the job to you and Astrid ?

Show
Christian Mueller added a comment - Nice, so I can stop watching this issue and leave the job to you and Astrid ?
Hide
Permalink
Frank Gasdorf added a comment -

Yes! Thanks for committing our patches!

Show
Frank Gasdorf added a comment - Yes! Thanks for committing our patches!
Hide
Permalink
Frank Gasdorf added a comment -

Astrid,
like Christian mentioned in his comment (http://jira.codehaus.org/browse/GEOS-4294?focusedCommentId=270554&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-270554) the 2.0.x branch isn't maintained anymore and on the LiveDVD is installed a 2.1.x Version.

I would suggest to update only the 2.1.x branch, would you agree on that?

Show
Frank Gasdorf added a comment - Astrid, like Christian mentioned in his comment (http://jira.codehaus.org/browse/GEOS-4294?focusedCommentId=270554&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-270554) the 2.0.x branch isn't maintained anymore and on the LiveDVD is installed a 2.1.x Version. I would suggest to update only the 2.1.x branch, would you agree on that?
Hide
Permalink
Frank Gasdorf added a comment -

created a crowdin.net project for easier collaboration on that for non developers (who don't have commit access) : http://j.mp/qfAfzg
Initially I uploaded the current property files from 2.1.x branch and afterwards the already translated files too.
Please review and contribute the outstanding properties, if completed, we can export the properties and commit to 2.1.x branch.

Show
Frank Gasdorf added a comment - created a crowdin.net project for easier collaboration on that for non developers (who don't have commit access) : http://j.mp/qfAfzg Initially I uploaded the current property files from 2.1.x branch and afterwards the already translated files too. Please review and contribute the outstanding properties, if completed, we can export the properties and commit to 2.1.x branch.
Hide
Permalink
Gabriel Roldán added a comment -

hey that crowdin.net thing looks great. I just joined, waiting for moderator approval.
Do you think we should propose that tool as the translation tool for geoserver?

Show
Gabriel Roldán added a comment - hey that crowdin.net thing looks great. I just joined, waiting for moderator approval. Do you think we should propose that tool as the translation tool for geoserver?
Hide
Permalink
Frank Gasdorf added a comment -

added 100% completed translation for German on 2.1.x, Ready for review in a running system.

Show
Frank Gasdorf added a comment - added 100% completed translation for German on 2.1.x, Ready for review in a running system.
Hide
Permalink
Andrea Aime added a comment -

Mass transition all resolved issue that did not see any further comment in the last month to closed status

Show
Andrea Aime added a comment - Mass transition all resolved issue that did not see any further comment in the last month to closed status

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.