GeoServer

NullPointerException happens if WMS casade layer is used inside LayerGroup

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.1-beta3
  • Fix Version/s: 2.1-RC1
  • Component/s: WMS
  • Labels:
    None
  • Patch Submitted:
    Yes
  • Number of attachments :
    5

Description

Last days I gave a spin to the new WMSCascadeLayer feature, and it seems its working pretty nice when single layer is used. But what I wanted to do is combine different layers from several external WMS servers + locally configured server. Following error was thrown:

ERROR [geoserver.ows] -
java.lang.NullPointerException
at org.geoserver.wms.map.GetMapKvpRequestReader.read(GetMapKvpRequestReader.java:318)
at org.geoserver.wms.map.GetMapKvpRequestReader.read(GetMapKvpRequestReader.java:1)
at org.geoserver.ows.Dispatcher.parseRequestKVP(Dispatcher.java:1144)
at org.geoserver.ows.Dispatcher.dispatch(Dispatcher.java:482)
at org.geoserver.ows.Dispatcher.handleRequestInternal(Dispatcher.java:226)

I took a look at the error and I figured it out that in the case of LayerGroupInfo single layer wasnt handled the same way as it was in single LayerInfo request. More precisely style wasn't handled correctly if the layer in the group was instance of WMSLayerInfo

Initial patch attached as well as the resulting layergroup image request
(from two external wms sources - atlas.gc.ca & wms.jpl.nasa.gov - and locally configured one topp:states)

Regards,
Ivan

  1. Text File
    wms_cascade_group.patch
    22/Dec/10 5:05 AM
    2 kB
    Ivan Grcic
  2. Text File
    wms_cascade_group2.patch
    22/Dec/10 5:11 AM
    4 kB
    Ivan Grcic
  3. Text File
    wms_cascade_group3.patch
    22/Dec/10 5:23 AM
    3 kB
    Ivan Grcic
  4. Text File
    wms_cascade_group4.patch
    22/Dec/10 10:06 AM
    3 kB
    Ivan Grcic
  1. wmsCascadeGroup.jpeg
    91 kB
    22/Dec/10 5:05 AM

Issue Links

depends upon

Improvement - An improvement or enhancement to an existing feature or task. GEOS-4275 Add support for cascaded WMS resources in MockData

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.
relates to

Improvement - An improvement or enhancement to an existing feature or task. GEOS-4277 Add tests for WMS cascading in the WMS module

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Ivan Grcic added a comment -

As the code is same as in LayerInfo case, maybe we can combine it into single method

(and can somebody please change in title casade -> cascade. tnx)

Show
Ivan Grcic added a comment - As the code is same as in LayerInfo case, maybe we can combine it into single method (and can somebody please change in title casade -> cascade. tnx)
Hide
Permalink
Ivan Grcic added a comment -

cleaned up some blanks

Show
Ivan Grcic added a comment - cleaned up some blanks
Hide
Permalink
Andrea Aime added a comment -

Looks good enough for starters, two observations:

  • it misses a test proving it works (and more importantly, making sure it will keep on working when other changes are made). Unfortunately I see there are no GetMap tests involving wms cascading... hmmm... adding support for that would take some experience with the GeoServerTestSupport internals, I guess I'll do it.
  • if you can avoid code that add an item to a list, make a call that returns the item to be added and add it into the caller (functional code), that is, instead of void setNewStyle() have a StyleInfo getDefaultStyle() method instead
Show
Andrea Aime added a comment - Looks good enough for starters, two observations: it misses a test proving it works (and more importantly, making sure it will keep on working when other changes are made). Unfortunately I see there are no GetMap tests involving wms cascading... hmmm... adding support for that would take some experience with the GeoServerTestSupport internals, I guess I'll do it. if you can avoid code that add an item to a list, make a call that returns the item to be added and add it into the caller (functional code), that is, instead of void setNewStyle() have a StyleInfo getDefaultStyle() method instead
Hide
Permalink
Andrea Aime added a comment -

Ok, looking into adding tests I discovered why there are no tests for wms cascading, because it's quite hard to add them, first we need to migrate MockData to generate the 2.0.x data dir format. Let's just go ahead and commit a cleaned up version of the latest patch, and open a new jira for adding wms cascading tests

Show
Andrea Aime added a comment - Ok, looking into adding tests I discovered why there are no tests for wms cascading, because it's quite hard to add them, first we need to migrate MockData to generate the 2.0.x data dir format. Let's just go ahead and commit a cleaned up version of the latest patch, and open a new jira for adding wms cascading tests
Hide
Permalink
Ivan Grcic added a comment -

Patch modified with Andreas suggestions taken into account

Show
Ivan Grcic added a comment - Patch modified with Andreas suggestions taken into account
Hide
Permalink
Andrea Aime added a comment -

Patch committed on trunk at r15207

Show
Andrea Aime added a comment - Patch committed on trunk at r15207
Hide
Permalink
Andrea Aime added a comment -

Mass closing all issues that have been in the resolved state for the last month without anyone commenting or reopening them

Show
Andrea Aime added a comment - Mass closing all issues that have been in the resolved state for the last month without anyone commenting or reopening them

People

  • Assignee:
    Andrea Aime
    Reporter:
    Ivan Grcic
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: