GeoServer

Enhance FormatOptionsKvpParser to support back slash escaping

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Trivial Trivial
  • Resolution: Fixed
  • Affects Version/s: 2.1-beta1
  • Fix Version/s: 2.1-RC2
  • Component/s: None
  • Labels:
    None
  • Testcase included:
    yes
  • Patch Submitted:
    Yes
  • Number of attachments :
    2

Description

The FormatOptionsKvpParser does not provide any escaping mechanism (I'm thinking along the lines of the comment in WFS 1.1.0 14.2.2). I don't know that this section of the specification is directly relevant but it does seem like FORMAT_OPTIONS (including VIEWPARAMS) should allow any values to be specified (particularly if character-based SQL parameters are being used). I have included an alternate implementation of FormatOptionsKvpParser that allows for values from KVPs to support backslash as an escape character and added supporting test cases.

  1. Text File
    format-options.notabs.patch
    09/Dec/10 1:02 PM
    8 kB
    Eli Miller
  2. Text File
    format-options.patch
    15/Oct/10 10:01 AM
    7 kB
    Eli Miller

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Andrea Aime added a comment -

The patch looks good to me. Justin, what do you think?

Show
Andrea Aime added a comment - The patch looks good to me. Justin, what do you think?
Hide
Permalink
Justin Deoliveira added a comment -

Yeah, codewise I agree the patch looks nice. Thanks Eli!

One thing though is that there seems to be some formatting issues. Eli, any chance you can reproduce the patch with spaces used for indent instead of tabs to avoid having mixed indentation in the files. Thanks!

Show
Justin Deoliveira added a comment - Yeah, codewise I agree the patch looks nice. Thanks Eli! One thing though is that there seems to be some formatting issues. Eli, any chance you can reproduce the patch with spaces used for indent instead of tabs to avoid having mixed indentation in the files. Thanks!
Hide
Permalink
Eli Miller added a comment -

I believe that this patch should get rid of all the tabs. I ran into some odd IDE oddities while creating this patch – please sanity check the outcome when applying the patch and let me know if anything goes awry. Thanks!

Show
Eli Miller added a comment - I believe that this patch should get rid of all the tabs. I ran into some odd IDE oddities while creating this patch – please sanity check the outcome when applying the patch and let me know if anything goes awry. Thanks!
Hide
Permalink
Andrea Aime added a comment -

This one was actually applied on trunk on Sun Dec 12 (r15161) by myself. But I forgot to close the issue, sorry.

Show
Andrea Aime added a comment - This one was actually applied on trunk on Sun Dec 12 (r15161) by myself. But I forgot to close the issue, sorry.
Hide
Permalink
Andrea Aime added a comment -

Mass closing all issues that have been in the resolved state for the last month without anyone commenting or reopening them

Show
Andrea Aime added a comment - Mass closing all issues that have been in the resolved state for the last month without anyone commenting or reopening them

People

  • Assignee:
    Andrea Aime
    Reporter:
    Eli Miller
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: