GeoServer

Really cache feature type attributes in resource pool

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 2.1.x
  • Component/s: Configuration
  • Labels:
    None
  • Number of attachments :
    1

Description

The resource pool contains a feature attribute cache that is not really in use (there is a TODO in the code).
The current code however calls directly for the attributes when building a feature source, so caching them has become critical.

The small patch attached enables effective caching, avoiding a scan of the data directory for the schema file every single time a feature source is build (e.g., for every request)

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Justin Deoliveira added a comment -

+1. Let's do it. I wonder though... this means that people will no longer be able to just drop a schema.xsd file into and place and have it take effect immediately. They will have to reload the catalog / clear the resource pool cache. Which personally i am fine with, i think it is a reasonable thing to ask of users but thought i would mention it since it will be a change in behaviour.

Show
Justin Deoliveira added a comment - +1. Let's do it. I wonder though... this means that people will no longer be able to just drop a schema.xsd file into and place and have it take effect immediately. They will have to reload the catalog / clear the resource pool cache. Which personally i am fine with, i think it is a reasonable thing to ask of users but thought i would mention it since it will be a change in behaviour.
Hide
Permalink
Andrea Aime added a comment -

The thing is, the schema affects also the feature type, which is cached. So after changing the schema.xsd file you already have to hit reload, otherwise you have an inconsistency between what DFT returns and what GetFeature returns.

Show
Andrea Aime added a comment - The thing is, the schema affects also the feature type, which is cached. So after changing the schema.xsd file you already have to hit reload, otherwise you have an inconsistency between what DFT returns and what GetFeature returns.
Hide
Permalink
Andrea Aime added a comment -

Applied some time ago too

Show
Andrea Aime added a comment - Applied some time ago too
Hide
Permalink
Andrea Aime added a comment -

Mass closing all issues that have been in the resolved state for the last month without anyone commenting or reopening them

Show
Andrea Aime added a comment - Mass closing all issues that have been in the resolved state for the last month without anyone commenting or reopening them

People

  • Assignee:
    Andrea Aime
    Reporter:
    Andrea Aime
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: