GeoServer

(The!) Memoryleak in RetypingFeatureSource

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 1.7.4, 2.0-RC1
  • Fix Version/s: 1.7.7, 2.0-RC2
  • Component/s: WMS
  • Labels:
    None
  • Number of attachments :
    0

Description

We have tracked down the memoryleaks we have been having with GeoServer and the ArcSDE and PostGIS datastores. The symptoms was that after 1000-1300 getmap requests GeoServer would OOM no matter what configuration you are using.

It seems to be a small error in adding removing feature listeners. The code to add a feature listener i alright:

listeners.put(listener, wrapper);
wrapped.addFeatureListener(wrapper);

but to remove is wrong:

wrapped.removeFeatureListener(listener);
listeners.remove(listener);

the

wrapped.removeFeatureListener(listener);

should be

wrapped.removeFeatureListener(wrapper);

Changing this have removed all our oom problems atm.

Issue Links

Activity

Hide
Andrea Aime added a comment -

Patch applied on 1.7.x and trunk. Thanks for providing it.
May I recommend you have a look into the associated issue as well? It hinders performance quite a bit, if you have time you should consider looking into it as well

Show
Andrea Aime added a comment - Patch applied on 1.7.x and trunk. Thanks for providing it. May I recommend you have a look into the associated issue as well? It hinders performance quite a bit, if you have time you should consider looking into it as well

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: