GeoServer
  1. GeoServer
  2. GEOS-325

DescribeResponse doesn't support booleans

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.3.0-beta
    • Fix Version/s: 1.3.0 RC6
    • Component/s: WFS
    • Labels:
      None
    • Number of attachments :
      3

      Description

      A call to the WFS getDescribeFeature service, for a FeatureType
      with no explicit schema defined, ends up calling:
      String org.vfny.geoserver.responses.wfs.DescribeResponse.generateFromSchema(FeatureType schema)

      that calls:
      org.geotools.gml.producer.FeatureTypeTransformer.transform(schema, writer);

      that in the end calls:
      org.geotools.gml.producer.FeatureTypeTransformer$FeatureTypeTranslator.encode(AttributeType attribute)

      This method is missing support for the Boolean type (and maybe for others), so an excpetion is thrown.
      I fixed this bug (for Boolean only), but I'm unsure if the org.geotools.gml.producer package is to be replaced by something better altogether or will stay with us a little more.

      Bye
      Paolo Rizzi

      1. DescribeResponse.java
        20 kB
        Paolo Rizzi
      2. DescribeResponse.java
        20 kB
        Paolo Rizzi
      3. FeatureTypeTransformer.java
        19 kB
        Paolo Rizzi

        Activity

        Hide
        dblasby added a comment -

        Paolo, could you commit the boolean fix?

        Show
        dblasby added a comment - Paolo, could you commit the boolean fix?
        Hide
        Paolo Rizzi added a comment -

        I''m very sorry!!! It seems that I overlooked that last comment about committing my fix!!!
        And it was two months ago!!! Sorry again...
        I'll do it as first thing on Monday!!!

        Bye
        Paolo Rizzi

        Show
        Paolo Rizzi added a comment - I''m very sorry!!! It seems that I overlooked that last comment about committing my fix!!! And it was two months ago!!! Sorry again... I'll do it as first thing on Monday!!! Bye Paolo Rizzi
        Hide
        Paolo Rizzi added a comment -

        I don't have commit rights, so here are the two fixed files (fixed lines marked as "SISfixed").
        FeatureTypeTransformer.java is really from GeoTools, so it would be better fixed there, not in GeoServer.
        DescribeResponse.java has no errors, I simply modified it to use it's own package version of FeatureTypeTransformer, instead of the one inside GeoTools.
        As soon as FeatureTypeTransformer will be fixed inside GeoTools, DescribeResponse may as it was.

        Bye
        Paolo Rizzi

        Show
        Paolo Rizzi added a comment - I don't have commit rights, so here are the two fixed files (fixed lines marked as "SISfixed"). FeatureTypeTransformer.java is really from GeoTools, so it would be better fixed there, not in GeoServer. DescribeResponse.java has no errors, I simply modified it to use it's own package version of FeatureTypeTransformer, instead of the one inside GeoTools. As soon as FeatureTypeTransformer will be fixed inside GeoTools, DescribeResponse may as it was. Bye Paolo Rizzi
        Hide
        Paolo Rizzi added a comment -

        I'm sorry, there was a few HTML lines inside the first version of the attached DescribeResponse.java

        Bye
        Paolo Rizzi

        Show
        Paolo Rizzi added a comment - I'm sorry, there was a few HTML lines inside the first version of the attached DescribeResponse.java Bye Paolo Rizzi
        Hide
        Brent Owens added a comment -

        Moved to 1.3.0-RC6

        Show
        Brent Owens added a comment - Moved to 1.3.0-RC6
        Hide
        Justin Deoliveira added a comment -

        apply changes at geotools level

        Show
        Justin Deoliveira added a comment - apply changes at geotools level
        Hide
        Andrea Aime added a comment -

        These issue has been in resolved state for at least one month (quite a bit, a lot more than one month). Batch transitioning them to closed state

        Show
        Andrea Aime added a comment - These issue has been in resolved state for at least one month (quite a bit, a lot more than one month). Batch transitioning them to closed state

          People

          • Assignee:
            Justin Deoliveira
            Reporter:
            Paolo Rizzi
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: