GeoServer

Runaway URL-encoding of featureType filenames

Details

  • Type: Bug Bug
  • Status: Reopened Reopened
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 1.7.4
  • Fix Version/s: None
  • Component/s: Configuration
  • Labels:
    None
  • Environment:
    MacOS 10.5, CentOS 5.0
  • Number of attachments :
    0

Description

When I create a featureType from a PostGIS table with a space in the name (eg. Foo Bar), I end up with directories in data/featureTypes that look like this:

postgis_Foo%252525252BBar

I assume that what is happening is this: The first time I save the featureType, it encodes the space as %2B. The next time I save the config (any part of it, I think), it reads that feature type filename, sees that it has a %, and encodes that as %25. The next time, it sees that it still contains a %, and encodes it again, ad infinitum. This repeats each time I make any changes to my config, until the filenames are longer than the legal filesystem limit. Then I can't save anything.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Daniel Lipsitt added a comment -

I noticed that there's an intermediate step where the spaces are encoded as plus signs. That's what %2B stands for. So it goes like this:

Foo Bar
Foo+Bar
Foo%2BBar
Foo%252BBar
Foo%25252BBar
...

Show
Daniel Lipsitt added a comment - I noticed that there's an intermediate step where the spaces are encoded as plus signs. That's what %2B stands for. So it goes like this: Foo Bar Foo+Bar Foo%2BBar Foo%252BBar Foo%25252BBar ...
Hide
Permalink
Justin Deoliveira added a comment -

Hi Daniel,

I can't seem to get by the Foo+Bar step. Can you give me teh exactly sequence of saves/loads/restarts involved so I can try to reproduce. Thanks.

Show
Justin Deoliveira added a comment - Hi Daniel, I can't seem to get by the Foo+Bar step. Can you give me teh exactly sequence of saves/loads/restarts involved so I can try to reproduce. Thanks.
Hide
Permalink
Daniel Lipsitt added a comment -

Justin,

  1. Start with a table in postgis called "Foo Bar".
  2. Add a featuretype for the table.
  3. Assuming the namespace for the featureType is "postgis," you should get a directory named postgis_Foo+Bar in your featureTypes dir.

However, I was unable just now to replicate the re-encoding of the plus signs to %2B. So the directories I was seeing with the extra encoding may have been from before I upgraded to 1.6.x.

Show
Daniel Lipsitt added a comment - Justin, Start with a table in postgis called "Foo Bar". Add a featuretype for the table. Assuming the namespace for the featureType is "postgis," you should get a directory named postgis_Foo+Bar in your featureTypes dir. However, I was unable just now to replicate the re-encoding of the plus signs to %2B . So the directories I was seeing with the extra encoding may have been from before I upgraded to 1.6.x.
Hide
Permalink
Daniel Lipsitt added a comment -

Can't reproduce in 1.7.4. Will re-open if it shows up again. Sorry to waste your time.

Show
Daniel Lipsitt added a comment - Can't reproduce in 1.7.4. Will re-open if it shows up again. Sorry to waste your time.
Hide
Permalink
Daniel Lipsitt added a comment -

Although I am not seeing runaway growth of file names in 1.7.5, I think there are still potential issues with the encoding.

For a layer named Foo Bar, I am getting both namespace_Foo+Bar and namespace_Foo%2BBar in my featureTypes directory.

I'm not totally sure about the sequence, but it looks like the plus sign version is saved first, and then the %-encoded version comes later when I save another change (anywhere in the config, I think). Strangely, it seems that it then saves it with the plus sign again at some later point.

My main concern is the duplication of the config for these layers. Which version of the file gets read in when the config is reloaded? It seems like there is a potential for the two versions to get out of sync and for the older one to be read in by mistake when the server is restarted.

Notice that %2B is the code for plus, not space. If the filename is going to be URL encoded, it should be %20. In any case, it just needs to be done consistently.

Show
Daniel Lipsitt added a comment - Although I am not seeing runaway growth of file names in 1.7.5, I think there are still potential issues with the encoding. For a layer named Foo Bar , I am getting both namespace_Foo+Bar and namespace_Foo%2BBar in my featureTypes directory. I'm not totally sure about the sequence, but it looks like the plus sign version is saved first, and then the %-encoded version comes later when I save another change (anywhere in the config, I think). Strangely, it seems that it then saves it with the plus sign again at some later point. My main concern is the duplication of the config for these layers. Which version of the file gets read in when the config is reloaded? It seems like there is a potential for the two versions to get out of sync and for the older one to be read in by mistake when the server is restarted. Notice that %2B is the code for plus, not space. If the filename is going to be URL encoded, it should be %20 . In any case, it just needs to be done consistently.
Hide
Permalink
Justin Deoliveira added a comment -

I still seem unable to reproduce this. It remains namespace_Foo+Bar through a variety of saves, loads, and restarts. I am running mac os x 10.5 as well. I wonder if it could be anything with your locale or file system? Does your file system any special options? Or just the defaults?

Show
Justin Deoliveira added a comment - I still seem unable to reproduce this. It remains namespace_Foo+Bar through a variety of saves, loads, and restarts. I am running mac os x 10.5 as well. I wonder if it could be anything with your locale or file system? Does your file system any special options? Or just the defaults?
Hide
Permalink
Daniel Lipsitt added a comment -

That's odd. My filesystem is standard. I'm using the .dmg package of Geoserver. Here's some info:

$ java -version
java version "1.5.0_16"
Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_16-b06-284)
Java HotSpot(TM) Client VM (build 1.5.0_16-133, mixed mode, sharing)

$ locale
LANG="en_US.UTF-8"
LC_COLLATE="en_US.UTF-8"
LC_CTYPE="en_US.UTF-8"
LC_MESSAGES="en_US.UTF-8"
LC_MONETARY="en_US.UTF-8"
LC_NUMERIC="en_US.UTF-8"
LC_TIME="en_US.UTF-8"
LC_ALL=

I'm seeing similar (or the same) problems on CentOS linux.

Are there other diagnostics I could do?

Show
Daniel Lipsitt added a comment - That's odd. My filesystem is standard. I'm using the .dmg package of Geoserver. Here's some info: $ java -version java version "1.5.0_16" Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_16-b06-284) Java HotSpot(TM) Client VM (build 1.5.0_16-133, mixed mode, sharing) $ locale LANG= "en_US.UTF-8" LC_COLLATE= "en_US.UTF-8" LC_CTYPE= "en_US.UTF-8" LC_MESSAGES= "en_US.UTF-8" LC_MONETARY= "en_US.UTF-8" LC_NUMERIC= "en_US.UTF-8" LC_TIME= "en_US.UTF-8" LC_ALL= I'm seeing similar (or the same) problems on CentOS linux. Are there other diagnostics I could do?

People

  • Assignee:
    Justin Deoliveira
    Reporter:
    Daniel Lipsitt
Vote (0)
Watch (0)

Dates

  • Created:
    Updated: