GeoServer
  1. GeoServer
  2. GEOS-3068

Saving existing coverage store brings to the "choose layer" page anyways

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0-beta1
    • Component/s: None
    • Labels:
      None
    • Number of attachments :
      0

      Description

      This is wrong, it should go back to the StorePage instead. When you add a new store it's pretty natural that you want to add layers too, when you save modifications to an existing store, it's not.

        Activity

        Hide
        Gabriel Roldan added a comment -

        Agreed. Still it brings out the concern that this way no validation is performed on the coverage store connection parameters whatsoever. It just gets saved verbatim but we don't know if the params are valid.
        Currently the only way of doing so (as for yesterday, wrong connection parameters produced an ugly exception page) is to instantiate the NewLayerPage AFTER saving the store, if that fails it means the coverage can't be retrieved, if NewLayerPage was instantiated it means it succeeed...
        As ugly as it is (sort of programming by coincidence) it is how it works right now.
        I guess for the CoverageStoreEditPage I could try and query for the coverage with the provided parameters before adding the store to the catalog? (that would save a manual rollback too..)

        Show
        Gabriel Roldan added a comment - Agreed. Still it brings out the concern that this way no validation is performed on the coverage store connection parameters whatsoever. It just gets saved verbatim but we don't know if the params are valid. Currently the only way of doing so (as for yesterday, wrong connection parameters produced an ugly exception page) is to instantiate the NewLayerPage AFTER saving the store, if that fails it means the coverage can't be retrieved, if NewLayerPage was instantiated it means it succeeed... As ugly as it is (sort of programming by coincidence) it is how it works right now. I guess for the CoverageStoreEditPage I could try and query for the coverage with the provided parameters before adding the store to the catalog? (that would save a manual rollback too..)
        Hide
        Andrea Aime added a comment -

        Agreed on trying to get the coverage information out of the updated store as a validation means.

        Show
        Andrea Aime added a comment - Agreed on trying to get the coverage information out of the updated store as a validation means.
        Hide
        Gabriel Roldan added a comment -

        added validation by means of getting a reader for the provided url and return to the StorePage in case of success

        Show
        Gabriel Roldan added a comment - added validation by means of getting a reader for the provided url and return to the StorePage in case of success

          People

          • Assignee:
            Gabriel Roldan
            Reporter:
            Andrea Aime
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: