GeoServer
  1. GeoServer
  2. GEOS-3063

Make sure GeoServer generates valid XHTML

    Details

    • Type: Task Task
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0-RC1
    • Component/s: None
    • Labels:
      None
    • Number of attachments :
      0

      Description

      Failure to comply to XHTML usually results in strange browser behaviour and CSS issues.
      The Firefox HTML Validator (http://users.skynet.be/mgueury/mozilla/download.html) can be used to check most of the failures. There are a few that I think we can ignore, such as:

      • not adding "alt" attribute to images
      • the xmlns:wicket="http://wicket.apache.org/" declaration
        but just on the home page the tool spots two unclosed input elements and a div inside an <a> element (that should not be there).

      There is also a validator in Wicket-stuff that can be used for the purpose in an automated fashion:
      http://github.com/dashorst/wicket-stuff-markup-validator/tree/master

        Activity

        Hide
        David Winslow added a comment -

        The following link may be helpful in dealing with this:
        http://cwiki.apache.org/WICKET/how-to-remove-wicket-markup-from-output.html

        Show
        David Winslow added a comment - The following link may be helpful in dealing with this: http://cwiki.apache.org/WICKET/how-to-remove-wicket-markup-from-output.html
        Hide
        Andrea Aime added a comment -

        Right, I knew about that , but xmlns:wicket="http://wicket.apache.org/" is added by us in the home page to have Eclipse validate the markup to start with, otherwise it will start yelling at us that the wicket:xxx elements and attributes are not valid. Thus, it's not removed when putting Wicket in deplyment mode (because we manually added it).

        Show
        Andrea Aime added a comment - Right, I knew about that , but xmlns:wicket="http://wicket.apache.org/" is added by us in the home page to have Eclipse validate the markup to start with, otherwise it will start yelling at us that the wicket:xxx elements and attributes are not valid. Thus, it's not removed when putting Wicket in deplyment mode (because we manually added it).
        Hide
        Andrea Aime added a comment -

        XHTML validation now passes in all pages besides the ones using the palette component, which emits invalid markup (see https://issues.apache.org/jira/browse/WICKET-2406).
        We need to work on a way to keep things this way, but I'll open another jira for that

        Show
        Andrea Aime added a comment - XHTML validation now passes in all pages besides the ones using the palette component, which emits invalid markup (see https://issues.apache.org/jira/browse/WICKET-2406 ). We need to work on a way to keep things this way, but I'll open another jira for that

          People

          • Assignee:
            Andrea Aime
            Reporter:
            Andrea Aime
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: