best_guess regionating strategy broken

Switching to geometry / the_geom without restart results in a stale lock. This is probably a secondary effect.

27 Apr 16:41:52 ERROR [data.shapefile] - The following locker still has a lock� read on file:/home/ak/gs/1.7.x/data/release/data/shapefiles/states.shx by org.geotools.data.shapefile.shp.IndexFile
it was created with the following stack trace
org.geotools.data.shapefile.ShpFilesLocker$Trace: Locking file:/home/ak/gs/1.7.x/data/release/data/shapefiles/states.shx for read by org.geotools.data.shapefile.shp.IndexFile in thread btpool0-39
at org.geotools.data.shapefile.ShpFilesLocker.setTraceException(ShpFilesLocker.java:54)
at org.geotools.data.shapefile.ShpFilesLocker.<init>(ShpFilesLocker.java:33)
at org.geotools.data.shapefile.ShpFiles.acquireRead(ShpFiles.java:365)
at org.geotools.data.shapefile.ShpFiles.getReadChannel(ShpFiles.java:813)
at org.geotools.data.shapefile.shp.IndexFile.<init>(IndexFile.java:78)
at org.geotools.data.shapefile.shp.ShapefileReader.<init>(ShapefileReader.java:162)
at org.geotools.data.shapefile.ShapefileDataStore.openShapeReader(ShapefileDataStore.java:425)
at org.geotools.data.shapefile.indexed.IndexedShapefileDataStore.getAttributesReader(IndexedShapefileDataStore.java:428)
at org.geotools.data.shapefile.indexed.IndexedShapefileDataStore.getFeatureReader(IndexedShapefileDataStore.java:330)
at org.geotools.data.AbstractDataStore.getFeatureReader(AbstractDataStore.java:385)
at org.geotools.data.DefaultFeatureResults.reader(DefaultFeatureResults.java:210)
at org.geotools.data.store.DataFeatureCollection.openIterator(DataFeatureCollection.java:229)
at org.geotools.data.store.DataFeatureCollection.iterator(DataFeatureCollection.java:199)
at org.geotools.data.store.DataFeatureCollection.features(DataFeatureCollection.java:188)
at org.geotools.data.crs.ForceCoordinateSystemFeatureResults.openIterator(ForceCoordinateSystemFeatureResults.java:93)
at org.geotools.feature.collection.AbstractFeatureCollection.features(AbstractFeatureCollection.java:64)
at org.vfny.geoserver.wms.responses.map.kml.ExternalSortRegionatingStrategy.buildIndex(ExternalSortRegionatingStrategy.java:206)
at org.vfny.geoserver.wms.responses.map.kml.ExternalSortRegionatingStrategy.getSortedFeatures(ExternalSortRegionatingStrategy.java:148)
at org.vfny.geoserver.wms.responses.map.kml.CachedHierarchyRegionatingStrategy.computeFids(CachedHierarchyRegionatingStrategy.java:404)
at org.vfny.geoserver.wms.responses.map.kml.CachedHierarchyRegionatingStrategy.readFeaturesForTile(CachedHierarchyRegionatingStrategy.java:301)
at org.vfny.geoserver.wms.responses.map.kml.CachedHierarchyRegionatingStrategy.getFeaturesForTile(CachedHierarchyRegionatingStrategy.java:265)
at org.vfny.geoserver.wms.responses.map.kml.CachedHierarchyRegionatingStrategy.getFilter(CachedHierarchyRegionatingStrategy.java:168)
at org.vfny.geoserver.wms.responses.map.kml.BestGuessRegionatingStrategy.getFilter(BestGuessRegionatingStrategy.java:43)
at org.vfny.geoserver.wms.responses.map.kml.KMLUtils.loadFeatureCollection(KMLUtils.java:492)
at org.vfny.geoserver.wms.responses.map.kml.KMLSuperOverlayTransformer$KMLSuperOverlayerTranslator.featuresInTile(KMLSuperOverlayTransformer.java:262)
at org.vfny.geoserver.wms.responses.map.kml.KMLSuperOverlayTransformer$KMLSuperOverlayerTranslator.shouldDrawVectorLayer(KMLSuperOverlayTransformer.java:161)
at org.vfny.geoserver.wms.responses.map.kml.KMLSuperOverlayTransformer$KMLSuperOverlayerTranslator.encodeTileForViewing(KMLSuperOverlayTransformer.java:138)
at org.vfny.geoserver.wms.responses.map.kml.KMLSuperOverlayTransformer$KMLSuperOverlayerTranslator.encode(KMLSuperOverlayTransformer.java:126)
at org.vfny.geoserver.wms.responses.map.kml.KMLTransformer$KMLTranslator.encodeSuperOverlayLayer(KMLTransformer.java:243)
at org.vfny.geoserver.wms.responses.map.kml.KMLTransformer$KMLTranslator.encode(KMLTransformer.java:128)
at org.geotools.xml.transform.TransformerBase$XMLReaderSupport.parse(TransformerBase.java:714)
at org.apache.xalan.transformer.TransformerIdentityImpl.transform(TransformerIdentityImpl.java:484)
at org.geotools.xml.transform.TransformerBase$Task.run(TransformerBase.java:296)
at org.geotools.xml.transform.TransformerBase.transform(TransformerBase.java:129)
at org.geotools.xml.transform.TransformerBase.transform(TransformerBase.java:108)
at org.vfny.geoserver.wms.responses.map.kml.KMZMapProducer.writeTo(KMZMapProducer.java:149)
at org.vfny.geoserver.wms.responses.GetMapResponse.writeTo(GetMapResponse.java:614)
at org.geoserver.ows.adapters.ResponseAdapter.write(ResponseAdapter.java:60)
at org.geoserver.ows.Dispatcher.response(Dispatcher.java:712)
at org.geoserver.ows.Dispatcher.handleRequestInternal(Dispatcher.java:216)
at org.springframework.web.servlet.mvc.AbstractController.handleRequest(AbstractController.java:153)
at org.springframework.web.servlet.mvc.SimpleControllerHandlerAdapter.handle(SimpleControllerHandlerAdapter.java:48)
at org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:875)
at org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:809)
at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:571)
at org.springframework.web.servlet.FrameworkServlet.doGet(FrameworkServlet.java:501)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:689)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:487)
at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1093)
at org.vfny.geoserver.filters.SetCharacterEncodingFilter.doFilter(SetCharacterEncodingFilter.java:108)
at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1084)
at org.acegisecurity.util.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:264)
at org.acegisecurity.intercept.web.FilterSecurityInterceptor.invoke(FilterSecurityInterceptor.java:107)
at org.acegisecurity.intercept.web.FilterSecurityInterceptor.doFilter(FilterSecurityInterceptor.java:72)
at org.acegisecurity.util.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:274)
at org.acegisecurity.ui.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:110)
at org.acegisecurity.util.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:274)
at org.acegisecurity.providers.anonymous.AnonymousProcessingFilter.doFilter(AnonymousProcessingFilter.java:125)
at org.acegisecurity.util.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:274)
at org.acegisecurity.ui.basicauth.BasicProcessingFilter.doFilter(BasicProcessingFilter.java:178)
at org.acegisecurity.util.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:274)
at org.acegisecurity.context.HttpSessionContextIntegrationFilter.doFilter(HttpSessionContextIntegrationFilter.java:229)
at org.acegisecurity.util.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:274)
at org.acegisecurity.util.FilterChainProxy.doFilter(FilterChainProxy.java:148)
at org.acegisecurity.util.FilterToBeanProxy.doFilter(FilterToBeanProxy.java:98)
at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1084)
at org.geoserver.filters.LoggingFilter.doFilter(LoggingFilter.java:73)
at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1084)
at org.geoserver.filters.ReverseProxyFilter.doFilter(ReverseProxyFilter.java:163)
at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1084)
at org.geoserver.filters.GZIPFilter.doFilter(GZIPFilter.java:47)
at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1084)
at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:360)
at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:181)
at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:726)
at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:405)
at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
at org.mortbay.jetty.Server.handle(Server.java:324)
at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:505)
at org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:828)
at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:514)
at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:211)
at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:380)
at org.mortbay.jetty.bio.SocketConnector$Connection.run(SocketConnector.java:228)
at org.mortbay.thread.BoundedThreadPool$PoolThread.run(BoundedThreadPool.java:450)
27 Apr 16:41:52 ERROR [data.shapefile] - The following locker still has a lock� read on file:/home/ak/gs/1.7.x/data/release/data/shapefiles/states.fix by org.geotools.data.shapefile.indexed.IndexedFidReader
it was created with the following stack trace

target:
SimpleFeatureTypeImpl http://www.openplans.org/toppstates identified extends Feature(the_geom:MultiPolygon,the_geom:MultiPolygon)

origional: [sic]
SimpleFeatureTypeImpl http://www.openplans.org/toppstates identified extends Feature(the_geom:MultiPolygon)

This seems fair enough, the troublemaker is

if (target.getAttributeCount() > origional.getAttributeCount()) {
            throw new IllegalArgumentException(
                "Unable to retype  FeatureReader<SimpleFeatureType, SimpleFeature> (origional does not cover requested type)");
        }

We get in trouble in IndexedShapefileDataStore(AbstractDataStore)

if (!featureType.equals(reader.getFeatureType())) {
            LOGGER.fine("Recasting feature type to subtype by using a ReTypeFeatureReader");
            reader = new ReTypeFeatureReader(reader, featureType, false);
        }

so I'm wondering whether we can change what feature type we request in order to avoid the ReType?

So that would probably be in BestGuessRegionatingStrategy.getFilter

The type there is

SimpleFeatureTypeImpl http://www.openplans.org/toppstates identified extends Feature(the_geom:the_geom,STATE_NAME:STATE_NAME,STATE_FIPS:STATE_FIPS,\
SUB_REGION:SUB_REGION,STATE_ABBR:STATE_ABBR,LAND_KM:LAND_KM,\
WATER_KM:WATER_KM,PERSONS:PERSONS,FAMILIES:FAMILIES,\
HOUSHOLD:HOUSHOLD,MALE:MALE,FEMALE:FEMALE,WORKERS:WORKERS,\
DRVALONE:DRVALONE,CARPOOL:CARPOOL,PUBTRANS:PUBTRANS,\
EMPLOYED:EMPLOYED,UNEMPLOY:UNEMPLOY,SERVICE:SERVICE,MANUAL:MANUAL,\
P_MALE_MALE,P_FEMALE_FEMALE,SAMP_POP:SAMP_POP)

Noticed it has been committed to 1.7.4, remember to forward port to 1.7.x and trunk

Ported to 1.7.x and trunk, fixed.

Reopening to assign to the proper version

http://fisheye.codehaus.org/changelog/geoserver/branches/1.7.x?cs=12276

I pulled it out again and left the bug open because I wasn't able to actually trigger the bug (after reverting the fix) using my test case, though with the fix both code paths are exercised. I'll have another look when my head is functioning properly again.