GeoServer
  1. GeoServer
  2. GEOS-294

Validation for .sld file needed.

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.2.3
    • Fix Version/s: 1.3-rc1
    • Component/s: Validation
    • Labels:
      None
    • Environment:
      Geoserver 1.2.3
    • Number of attachments :
      0

      Description

      I'm using Geoserver 1.2.3 and there is no validation performed on a .sld file when it is being uploaded. Perhaps a warning message would be nice when trying to submit an invalid .sld file.

        Issue Links

          Activity

          Hide
          Chris Holmes added a comment -

          Related issue, should be solved at the same time.

          Show
          Chris Holmes added a comment - Related issue, should be solved at the same time.
          Hide
          Chris Holmes added a comment -

          Over to you dblasby - I thought this was in jira...

          Show
          Chris Holmes added a comment - Over to you dblasby - I thought this was in jira...
          Hide
          Chris Holmes added a comment -

          Ok, we now do a bit of validation. It will definitely get any xml errors, or catch if its not xml. So that's a nice start, does the good SAX reporting. Unfortunately if you do submit valid xml, our error reporting than SUCKS! Mostly due to the poor quality of the SLD DOM parser that we use. I would add better (any?) error messages to it, but I hate the class in principle, and think the time would be better spent rewriting into a SAX SLD parser, or one based on the new xml framework. But you will not be able to put an SLD file that would mysteriously disappear with no warning.

          Show
          Chris Holmes added a comment - Ok, we now do a bit of validation. It will definitely get any xml errors, or catch if its not xml. So that's a nice start, does the good SAX reporting. Unfortunately if you do submit valid xml, our error reporting than SUCKS! Mostly due to the poor quality of the SLD DOM parser that we use. I would add better (any?) error messages to it, but I hate the class in principle, and think the time would be better spent rewriting into a SAX SLD parser, or one based on the new xml framework. But you will not be able to put an SLD file that would mysteriously disappear with no warning.

            People

            • Assignee:
              Chris Holmes
              Reporter:
              Paul Duff
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour
                1h