GeoServer

Merge GeoServerUserDao and EditableUserDao into one class

Details

  • Type: Task Task
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: UNRESOLVED
  • Affects Version/s: None
  • Fix Version/s: 2.0.x
  • Component/s: Security
  • Labels:
    None
  • Number of attachments :
    1

Description

I pimped up GeoServerUserDao to support editing for the Wicket UI and only after finishing and trying to move to another task I noticed this EditableUserDao that does basically the same thing... agh!
Merge the two functionality wise and switch all users to just one of them.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Andrea Aime added a comment -

Hmmm... notihng on trunk is using EditableUserDao?

Show
Andrea Aime added a comment - Hmmm... notihng on trunk is using EditableUserDao?
Hide
Permalink
David Winslow added a comment -

Just the user editing service in the QueryUsers community module. I don't know if that module has been ported to trunk off the top of my head.

Show
David Winslow added a comment - Just the user editing service in the QueryUsers community module. I don't know if that module has been ported to trunk off the top of my head.
Hide
Permalink
Chris McMillan added a comment -

Since it appears that this is a low hanging fruit that is mainly used for testing. I hope that no one takes offense but I have attached a patch that updates QueryUsers to use GeoServerUserDao. I added two methods from EditableUserDao to GeoServerUserDao that were needed for porting, setUserDetails() and makeUser(). I have attached the patch file for review.

Show
Chris McMillan added a comment - Since it appears that this is a low hanging fruit that is mainly used for testing. I hope that no one takes offense but I have attached a patch that updates QueryUsers to use GeoServerUserDao. I added two methods from EditableUserDao to GeoServerUserDao that were needed for porting, setUserDetails() and makeUser(). I have attached the patch file for review.
Hide
Permalink
Andrea Aime added a comment -

Does this still make any sense after the 2.2.x changes in the security subsystem?

Show
Andrea Aime added a comment - Does this still make any sense after the 2.2.x changes in the security subsystem?
Hide
Permalink
David Winslow added a comment -

I think it doesn't. The new system introduces GeoServerUserGroupService and GeoServerUserGroupStore and its own idioms (service.getStore()) for testing whether the user service is capable of storing/writing changes to users. I see GeoServerUserDao and EditableUserDao are still around, but EditableUserDao doesn't seem to be referenced anywhere.

Show
David Winslow added a comment - I think it doesn't. The new system introduces GeoServerUserGroupService and GeoServerUserGroupStore and its own idioms (service.getStore()) for testing whether the user service is capable of storing/writing changes to users. I see GeoServerUserDao and EditableUserDao are still around, but EditableUserDao doesn't seem to be referenced anywhere.
Hide
Permalink
Andrea Aime added a comment -

Switching all issues that have been in "resolved" state for more than one month without further comments to "closed" status

Show
Andrea Aime added a comment - Switching all issues that have been in "resolved" state for more than one month without further comments to "closed" status

People

  • Assignee:
    Andrea Aime
    Reporter:
    Andrea Aime
Vote (0)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: