GeoServer

KMLSuperOverlayTransformer does not pass format_options along when encoding link to next level of hierachy

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 1.7.1
  • Component/s: Google Earth KML Output
  • Labels:
    None
  • Number of attachments :
    0

Description

Not sure if this is a bug or intended behaviour. But in KMLSuperOverlayTransformer#encodeKMLLink() the original format options are completely ignored.

Also, it seems like the only possible regionateMode can be overview or auto, is this desired behaviour?

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Justin Deoliveira added a comment -

OK.. perhaps this is intended... i tried patching this and it send the h2 watchdog thread into a frenzy that more or less crashes the server.

Show
Justin Deoliveira added a comment - OK.. perhaps this is intended... i tried patching this and it send the h2 watchdog thread into a frenzy that more or less crashes the server.
Hide
Permalink
David Winslow added a comment -

The reason the format options are overwritten is that we need to disable superoverlays for the vector tiles that are being included. In overview mode we don't want to filter the results (we don't show vector data until we ONLY show vector data) so we turn off regionating for those tiles entirely. Otherwise we override some of the request parameters so that the linked tile contains placemarks instead of more network links. We probably should be merging the format_options instead of overwriting them; I feel like I thought the WMSRequests utility class would handle that when I was writing this code but clearly it does not.

Show
David Winslow added a comment - The reason the format options are overwritten is that we need to disable superoverlays for the vector tiles that are being included. In overview mode we don't want to filter the results (we don't show vector data until we ONLY show vector data) so we turn off regionating for those tiles entirely. Otherwise we override some of the request parameters so that the linked tile contains placemarks instead of more network links. We probably should be merging the format_options instead of overwriting them; I feel like I thought the WMSRequests utility class would handle that when I was writing this code but clearly it does not.
Hide
Permalink
Andrea Aime added a comment -

Mass close all issues that have been resolved for more than one month without further comments (assuming they are fixed for good since there is no more discussion)

Show
Andrea Aime added a comment - Mass close all issues that have been resolved for more than one month without further comments (assuming they are fixed for good since there is no more discussion)

People

  • Assignee:
    David Winslow
    Reporter:
    Justin Deoliveira
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: