GeoServer

OWSUtils application generates sizeable amount of heap garbage

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.7.0-RC2
  • Fix Version/s: 1.7.0-RC3
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    2

Description

A WMS memory profiling sessions showed that OWSUtils class, called very often by the dispatcher, generates a very sizeable amount of garbage, second only to the very BufferedImages allocated to draw the images. The memory profiler showed somethign along the line of 18MB of buffered images, and 14MB of Method[] and StringBuilder objects coming out of OWSUtils.

I've reworked OWSUtils into a cacheable structure that avoids most allocations and lookups, and that solves GEOS-749 and GEOS-2218 as well. Given it makes quite a difference in benchmarks I'm developing for FOSS4G, is it ok to commit it right away?
I can add some testing as well (OWSUtils has none, at least not directly)

Attachments

  1. Java Source File
    ClassProperties.java
    15/Sep/08 4:29 AM
    4 kB
    Andrea Aime
  2. Java Source File
    OwsUtils.java
    15/Sep/08 4:29 AM
    4 kB
    Andrea Aime

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Andrea Aime added a comment -

Here are the reworked OwsUtils and the associated ClassProperties file.

Show
Andrea Aime added a comment - Here are the reworked OwsUtils and the associated ClassProperties file.
Hide
Permalink
Justin Deoliveira added a comment -

Looks good, feel free to commit at your leisure... or would you rather me apply them... sounds like these changes are already sitting on your disk...

Show
Justin Deoliveira added a comment - Looks good, feel free to commit at your leisure... or would you rather me apply them... sounds like these changes are already sitting on your disk...
Hide
Permalink
Justin Deoliveira added a comment -

great work on the patch, i did not change anything... just some javadocs

Show
Justin Deoliveira added a comment - great work on the patch, i did not change anything... just some javadocs
Hide
Permalink
Andrea Aime added a comment -

All these issues have been in "resolved" state for at least one month (many of them, much more than that). Since no one has reopened them, I'm mass-switching them to closed state. Reopen if you feel the issue has not been addressed properly.

Show
Andrea Aime added a comment - All these issues have been in "resolved" state for at least one month (many of them, much more than that). Since no one has reopened them, I'm mass-switching them to closed state. Reopen if you feel the issue has not been addressed properly.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.