GeoServer

FeatureID Filter returns Wrong Result for shapefiles

Details

  • Number of attachments :
    0

Description

When I request multiple features using a FeatureId filter, I do not get them all back, though the features I requested do exist in the database.

Here's an example. Click on the link below and take a look at the URL.

http://tinyurl.com/3gjdom

I'm requesting six features, and I only get three back.

To see that these features do exist, the following requests those features in a different way.

http://pastebin.com/m69acc0f3

Issue Links

depends upon

Bug - A problem which impairs or prevents the functions of the product. GEOT-2050 IndexexShapefileDataStore produces inaccurate results with fid filters

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Andrea Aime added a comment -

Hum, this is bad. First off, we need to reproduce this on a developer's machine. How do we get a dump of the demo data?

Show
Andrea Aime added a comment - Hum, this is bad. First off, we need to reproduce this on a developer's machine. How do we get a dump of the demo data?
Hide
Permalink
Tim Coulter added a comment -

You can reproduce it using the following command on your local geoserver instance:

/geoserver/wfs?request=getfeature&propertyName=STATE_NAME&typename=topp:states&featureid=states.29,states.8,states.40,states.34,states.47,states.49

I've gone through this with dwinslow, and it looks to be shapefile specific.

Show
Tim Coulter added a comment - You can reproduce it using the following command on your local geoserver instance: /geoserver/wfs?request=getfeature&propertyName=STATE_NAME&typename=topp:states&featureid=states.29,states.8,states.40,states.34,states.47,states.49 I've gone through this with dwinslow, and it looks to be shapefile specific.
Hide
Permalink
David Winslow added a comment -

Just to clarify a bit: We were able to reproduce the problem on the states shapefile from the release data, but not on a postgis table created from that shapefile.

Show
David Winslow added a comment - Just to clarify a bit: We were able to reproduce the problem on the states shapefile from the release data, but not on a postgis table created from that shapefile.
Hide
Permalink
Justin Deoliveira added a comment -

This sounds to me like the issue of identifiers with non jdbc based datastores does it not? Any identifier you get back from a transaction against a shapefile is unfortunately unreliable. It is a known issue and one that is going to be tough to solve.

Show
Justin Deoliveira added a comment - This sounds to me like the issue of identifiers with non jdbc based datastores does it not? Any identifier you get back from a transaction against a shapefile is unfortunately unreliable. It is a known issue and one that is going to be tough to solve.
Hide
Permalink
Andrea Aime added a comment -

I debugged a little and I can confirm the problem is with the IndexedShapefileDataStore impleemntation. The feature index (.fix) is either broken, or badly read, element 47 cannot be found. I forced the recreation of the index and the problem still occurs, so the issue must be looked into that, either in the index writer, or in the index reader.

Show
Andrea Aime added a comment - I debugged a little and I can confirm the problem is with the IndexedShapefileDataStore impleemntation. The feature index (.fix) is either broken, or badly read, element 47 cannot be found. I forced the recreation of the index and the problem still occurs, so the issue must be looked into that, either in the index writer, or in the index reader.
Hide
Permalink
Chris Holmes added a comment -

Gabriel, can you look in to this? Higher priority than WMS tests, though lower than first round of ND work.

Show
Chris Holmes added a comment - Gabriel, can you look in to this? Higher priority than WMS tests, though lower than first round of ND work.
Hide
Permalink
Chris Holmes added a comment -

Also I feel like this is a duplicate, like it's been reported before, but I don't have the time to find the issue right now.

Show
Chris Holmes added a comment - Also I feel like this is a duplicate, like it's been reported before, but I don't have the time to find the issue right now.
Hide
Permalink
Gabriel Roldan added a comment -

linked to the related geotools issue

Show
Gabriel Roldan added a comment - linked to the related geotools issue
Hide
Permalink
Gabriel Roldan added a comment -

The related issue with IndexedShapefileDataStore is resolved and now the requested fids are found

Show
Gabriel Roldan added a comment - The related issue with IndexedShapefileDataStore is resolved and now the requested fids are found

People

  • Assignee:
    Gabriel Roldan
    Reporter:
    Tim Coulter
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: