GeoServer

Create BBOX Wicket Component

Details

  • Type: Task Task
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 2.0-beta1
  • Component/s: Wicket UI
  • Labels:
    None
  • Number of attachments :
    1

Description

Factor out the BBOX field in forms into a Wicket Component, then make that component nice for editing forms. (It can just be separate fields for each component of the bbox for now, but neat features could be added later and shared everywhere the component is used)

Ensure that the component is used wherever BBOXes are to be edited.

Issue Links

depends upon

Improvement - An improvement or enhancement to an existing feature or task. GEOS-2759 Factory out SRSList demo into reusable component.

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
is depended upon by

Task - A task that needs to be done. GEOS-2705 Wicket UI styling and usability improvements

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.

Activity

Ascending order - Click to sort in descending order
David Winslow made changes -
Field Original Value New Value
Fix Version/s 2.0 [ 10832 ]
Hide
Permalink
Andrea Aime added a comment -

Some requirements for this component:

  • four separate text boxes with i18n labels
  • the components is srs aware, so it will report lon/lat or x/y according to the kind of srs, geographic, or projected.
  • validation wise, makes sure the values are numbers, that they are properly associated (minx<maxx), and may issue a warning in case the bbox goes beyond the range of coordinates of the srs
  • can eat and return the various kinds of envelopes we play with (ReferencedEnvelope or GeneralEnvelope).

Anything else?

Show
Andrea Aime added a comment - Some requirements for this component: four separate text boxes with i18n labels the components is srs aware, so it will report lon/lat or x/y according to the kind of srs, geographic, or projected. validation wise, makes sure the values are numbers, that they are properly associated (minx<maxx), and may issue a warning in case the bbox goes beyond the range of coordinates of the srs can eat and return the various kinds of envelopes we play with (ReferencedEnvelope or GeneralEnvelope). Anything else?
Hide
Permalink
Andrea Aime added a comment -

Ah, we also want to make it uneditable, so that it can be used as a display component.

Show
Andrea Aime added a comment - Ah, we also want to make it uneditable, so that it can be used as a display component.
Hide
Permalink
Andrea Aime added a comment -

Chris, anything to add from a design point of view? I'm attaching a screenshot of the old one, I'd like to replicate it pretty much the same in the new UI. Please provide feedback as you see fit.

Show
Andrea Aime added a comment - Chris, anything to add from a design point of view? I'm attaching a screenshot of the old one, I'd like to replicate it pretty much the same in the new UI. Please provide feedback as you see fit.
Andrea Aime made changes -
Attachment bboxEditor.png [ 36357 ]
Hide
Permalink
Chris Patterson added a comment -

Not really anything to add from me - the current (old) approach seems fairly sane. If you run aground on markup or styling for these, give a holler and I'll see what I can do.

Show
Chris Patterson added a comment - Not really anything to add from me - the current (old) approach seems fairly sane. If you run aground on markup or styling for these, give a holler and I'll see what I can do.
Hide
Permalink
Gabriel Roldan added a comment - - edited

As for requirements, I'd like to add these ones to the list:

  • Get the axis names from the CRS, may be use the names as keys for i18n
  • Report the axis units as a label at the right of the text field
  • Replace req. #1 above by: respect the CRS dimension by presenting as many input fields as dimensions the CRS has
Show
Gabriel Roldan added a comment - - edited As for requirements, I'd like to add these ones to the list: Get the axis names from the CRS, may be use the names as keys for i18n Report the axis units as a label at the right of the text field Replace req. #1 above by: respect the CRS dimension by presenting as many input fields as dimensions the CRS has
Hide
Permalink
David Winslow added a comment -

<gallery class="peanut">
Just want to add that if we are pulling i18n keys from somewhere outside the markup we should probably be prepared for keys that aren't defined (just fall back to displaying the literal text) This may be inapplicable for this context, I don't know whether CRSs allow free axis units or have a known, finite set of possible values.
</gallery>

Show
David Winslow added a comment - <gallery class="peanut"> Just want to add that if we are pulling i18n keys from somewhere outside the markup we should probably be prepared for keys that aren't defined (just fall back to displaying the literal text) This may be inapplicable for this context, I don't know whether CRSs allow free axis units or have a known, finite set of possible values. </gallery>
Andrea Aime made changes -
Link This issue is depended upon by GEOS-2705 [ GEOS-2705 ]
Justin Deoliveira made changes -
Original Estimate 2 days [ 172800 ]
Remaining Estimate 2 days [ 172800 ]
Justin Deoliveira made changes -
Assignee Andrea Aime [ aaime ] Justin Deoliveira [ jdeolive ]
Justin Deoliveira made changes -
Link This issue depends upon GEOS-2759 [ GEOS-2759 ]
Hide
Permalink
Andrea Aime added a comment -

Justin, the component is basically made already, thought it has layout issues when mixed with other components. It should stay on a row of its own.

Show
Andrea Aime added a comment - Justin, the component is basically made already, thought it has layout issues when mixed with other components. It should stay on a row of its own.
Hide
Permalink
Justin Deoliveira added a comment -

Tenzo fixed this alignment issue. Closing this off. Any other issues can be opened separately.

Show
Justin Deoliveira added a comment - Tenzo fixed this alignment issue. Closing this off. Any other issues can be opened separately.
Justin Deoliveira made changes -
Status Open [ 1 ] Resolved [ 5 ]
Fix Version/s 2.0.x [ 10832 ]
Fix Version/s 2.0-beta1 [ 15082 ]
Resolution Fixed [ 1 ]
Hide
Permalink
Andrea Aime added a comment -

Mass closing all resolved issues that have been closed for more than one month without further comments

Show
Andrea Aime added a comment - Mass closing all resolved issues that have been closed for more than one month without further comments
Andrea Aime made changes -
Status Resolved [ 5 ] Closed [ 6 ]

People

  • Assignee:
    Justin Deoliveira
    Reporter:
    David Winslow
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:

Time Tracking

Estimated:
2d
Original Estimate - 2 days
Remaining:
2d
Remaining Estimate - 2 days
Logged:
Not Specified
Time Spent - Not Specified