GeoServer

Dispatcher uses highest version when no version match is possible

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 1.7.0-beta1
  • Fix Version/s: None
  • Component/s: WCS
  • Labels:
    None
  • Number of attachments :
    0

Description

When running WCS tests a request with version=0.0.0 is made, and the code without cite hacks returns 1.1.0, that is, if no match, return the highest... isn't this a little excessive leniency?

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Justin Deoliveira added a comment -

I would expect the behaviour to return 1.0.0... since 0.0.0 is less than 1.0.0. Or at least that is how the ows 1.0 style version negotiation works. I also don't seem to be able to replcate with any wcs requests... perhaps you already made this strict for that service.

Anyways, my answer is this. For GetCapabilities we have to be lenient to do version negotiation. But you are correct, for other operations we could be strict and tie them to versions we know about.

For now i am going to move this back to 1.7.1 since its not a critical issue. I will raise with Andrea when 1.7.1 comes up and he is back from vacation :

Show
Justin Deoliveira added a comment - I would expect the behaviour to return 1.0.0... since 0.0.0 is less than 1.0.0. Or at least that is how the ows 1.0 style version negotiation works. I also don't seem to be able to replcate with any wcs requests... perhaps you already made this strict for that service. Anyways, my answer is this. For GetCapabilities we have to be lenient to do version negotiation. But you are correct, for other operations we could be strict and tie them to versions we know about. For now i am going to move this back to 1.7.1 since its not a critical issue. I will raise with Andrea when 1.7.1 comes up and he is back from vacation :
Hide
Permalink
Andrea Aime added a comment -

Back from vacation! (kidding, just going thru the 1.7.4 issues to see what's to solve).
Does this require a big patch?

Show
Andrea Aime added a comment - Back from vacation! (kidding, just going thru the 1.7.4 issues to see what's to solve). Does this require a big patch?
Hide
Permalink
Justin Deoliveira added a comment -

I don't think it would take much. Basically just modify findService to check in the non getcaps case that there is a strict version match.

Show
Justin Deoliveira added a comment - I don't think it would take much. Basically just modify findService to check in the non getcaps case that there is a strict version match.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.