GeoServer

Linestring data type containing 1 point causes errors

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.6.0-RC1
  • Fix Version/s: 2.3-beta1
  • Component/s: PostGIS
  • Labels:
    None
  • Number of attachments :
    0

Description

I have a PostGIS view that constructs lines from a series of points using the ST_makeline function. If the series of points happens to be a single point, GeoServer throws errors when the featuretype is requsted.

-------------- Example View that constructs a Linestring from a series of point geometries ---------
CREATE OR REPLACE VIEW v_vehicle_lines AS
SELECT obs.vehicleid, obs.obs_date, count(obs.vehicleid) AS obs_count, min(obs.datestamp) AS min_time, max(obs.datestamp) AS max_time, (max(obs.datestamp) - min(obs.datestamp))::time without time zone AS elapsed_time, st_makeline(obs.geom) AS route_geom
FROM ( SELECT v_truck_obs.vehicleid, v_truck_obs.datestamp, date_trunc('day'::text, v_truck_obs.datestamp) AS obs_date, v_truck_obs.geom
FROM v_truck_obs
ORDER BY v_truck_obs.datestamp) obs
GROUP BY obs.vehicleid, obs.obs_date
ORDER BY obs.vehicleid, obs.obs_date;

----- ERRORS thrown ----------

02 Jun 15:17:07 WARN [org.geoserver.ows] -
java.io.IOException
at org.vfny.geoserver.wms.responses.map.kml.KMZMapProducer.writeTo(KMZMapProducer.java:133)
at org.vfny.geoserver.wms.responses.GetMapResponse.writeTo(GetMapResponse.java:561)
at org.geoserver.ows.adapters.ResponseAdapter.write(ResponseAdapter.java:60)
at org.geoserver.ows.Dispatcher.response(Dispatcher.java:608)
at org.geoserver.ows.Dispatcher.handleRequestInternal(Dispatcher.java:192)
at org.springframework.web.servlet.mvc.AbstractController.handleRequest(AbstractController.java:139)
at org.springframework.web.servlet.mvc.SimpleControllerHandlerAdapter.handle(SimpleControllerHandlerAdapter.java:44)
at org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:684)
at org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:625)
at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:392)
at org.springframework.web.servlet.FrameworkServlet.doGet(FrameworkServlet.java:347)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:689)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:459)
at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1054)
at org.acegisecurity.util.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:264)
at org.acegisecurity.intercept.web.FilterSecurityInterceptor.invoke(FilterSecurityInterceptor.java:107)
at org.acegisecurity.intercept.web.FilterSecurityInterceptor.doFilter(FilterSecurityInterceptor.java:72)
at org.acegisecurity.util.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:274)
at org.acegisecurity.ui.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:110)
at org.acegisecurity.util.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:274)
at org.acegisecurity.providers.anonymous.AnonymousProcessingFilter.doFilter(AnonymousProcessingFilter.java:125)
at org.acegisecurity.util.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:274)
at org.acegisecurity.ui.basicauth.BasicProcessingFilter.doFilter(BasicProcessingFilter.java:178)
at org.acegisecurity.util.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:274)
at org.acegisecurity.context.HttpSessionContextIntegrationFilter.doFilter(HttpSessionContextIntegrationFilter.java:229)
at org.acegisecurity.util.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:274)
at org.acegisecurity.util.FilterChainProxy.doFilter(FilterChainProxy.java:148)
at org.acegisecurity.util.FilterToBeanProxy.doFilter(FilterToBeanProxy.java:98)
at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1045)
at org.vfny.geoserver.filters.SetCharacterEncodingFilter.doFilter(SetCharacterEncodingFilter.java:108)
at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1045)
at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:358)
at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:231)
at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:629)
at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:453)
at org.mortbay.jetty.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:149)
at org.mortbay.jetty.handler.HandlerCollection.handle(HandlerCollection.java:123)
at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:141)
at org.mortbay.jetty.Server.handle(Server.java:303)
at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:452)
at org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:721)
at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:509)
at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:209)
at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:349)
at org.mortbay.io.nio.SelectChannelEndPoint.run(SelectChannelEndPoint.java:320)
at org.mortbay.thread.BoundedThreadPool$PoolThread.run(BoundedThreadPool.java:475)
Caused by: javax.xml.transform.TransformerException: Translator error
at org.geotools.xml.transform.TransformerBase.transform(TransformerBase.java:132)
at org.geotools.xml.transform.TransformerBase.transform(TransformerBase.java:107)
at org.vfny.geoserver.wms.responses.map.kml.KMZMapProducer.writeTo(KMZMapProducer.java:130)
... 46 more
Caused by: java.util.NoSuchElementException: Could not obtain the next feature:org.geotools.data.DataSourceException: An exception occurred while parsing WKB data
at org.geotools.data.store.FeatureReaderIterator.next(FeatureReaderIterator.java:67)
at org.geotools.feature.collection.DelegateFeatureIterator.next(DelegateFeatureIterator.java:54)
at org.geotools.data.crs.ForceCoordinateSystemIterator.next(ForceCoordinateSystemIterator.java:120)
at org.geotools.feature.collection.DelegateFeatureIterator.next(DelegateFeatureIterator.java:54)
at org.vfny.geoserver.wms.responses.map.kml.KMLVectorTransformer$KMLTranslator.encode(KMLVectorTransformer.java:266)
at org.vfny.geoserver.wms.responses.map.kml.KMLVectorTransformer$KMLTranslator.encode(KMLVectorTransformer.java:241)
at org.vfny.geoserver.wms.responses.map.kml.KMLTransformer$KMLTranslator.encodeVectorLayer(KMLTransformer.java:190)
at org.vfny.geoserver.wms.responses.map.kml.KMLTransformer$KMLTranslator.encode(KMLTransformer.java:126)
at org.geotools.xml.transform.TransformerBase$XMLReaderSupport.parse(TransformerBase.java:702)
at org.apache.xalan.transformer.TransformerIdentityImpl.transform(TransformerIdentityImpl.java:484)
at org.geotools.xml.transform.TransformerBase$Task.run(TransformerBase.java:295)
at org.geotools.xml.transform.TransformerBase.transform(TransformerBase.java:128)
... 48 more
Caused by: org.geotools.data.DataSourceException: An exception occurred while parsing WKB data
at org.geotools.data.postgis.attributeio.PgWKBAttributeIO.WKB2Geometry(PgWKBAttributeIO.java:113)
at org.geotools.data.postgis.attributeio.PgWKBAttributeIO.read(PgWKBAttributeIO.java:184)
at org.geotools.data.jdbc.QueryData.read(QueryData.java:212)
at org.geotools.data.jdbc.JDBCFeatureReader.readFeature(JDBCFeatureReader.java:107)
at org.geotools.data.jdbc.JDBCFeatureReader.next(JDBCFeatureReader.java:88)
at org.geotools.data.store.FeatureReaderIterator.next(FeatureReaderIterator.java:64)
... 59 more
Caused by: java.lang.IllegalArgumentException: point array must contain 0 or >1 elements
at com.vividsolutions.jts.geom.LineString.init(LineString.java:83)
at com.vividsolutions.jts.geom.LineString.<init>(LineString.java:74)
at com.vividsolutions.jts.geom.GeometryFactory.createLineString(GeometryFactory.java:470)
at com.vividsolutions.jts.io.WKBReader.readLineString(WKBReader.java:210)
at com.vividsolutions.jts.io.WKBReader.readGeometry(WKBReader.java:171)
at com.vividsolutions.jts.io.WKBReader.read(WKBReader.java:137)
at com.vividsolutions.jts.io.WKBReader.read(WKBReader.java:118)
at org.geotools.data.postgis.attributeio.PgWKBAttributeIO.WKB2Geometry(PgWKBAttributeIO.java:111)
... 64 more

-------------Work around-------------------
The errors can be avoided by creating a view that only returns Linestring geometries where the number of points is greater than 1, and basing then create the GeoServer featuretype using this view.

CREATE OR REPLACE VIEW geoserver.v_vehicle_trip AS
SELECT vehicleid, roi_id, vehicle_trip_no, num_obs, datestamp_start,
datestamp_end, geom
FROM v_vehicle_trip
WHERE ST_NumPoints("geom")>1;

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Andrea Aime added a comment -

My first reaction would be that the linestring is not actually valid compared to the simple feature model, so it's the data being broken, not the software... As you can see the error is thrown by JTS, so we'd have to convince Martin Davis to change its code and wait for a new JTS release... which may take another 6 months.
If the simple feature specification backs the idea that the linestring is valid nevertheless, it may be worth it, otherwise, it's probably not? What do you think?

Show
Andrea Aime added a comment - My first reaction would be that the linestring is not actually valid compared to the simple feature model, so it's the data being broken, not the software... As you can see the error is thrown by JTS, so we'd have to convince Martin Davis to change its code and wait for a new JTS release... which may take another 6 months. If the simple feature specification backs the idea that the linestring is valid nevertheless, it may be worth it, otherwise, it's probably not? What do you think?
Hide
Permalink
Tyler Erickson added a comment -

I think the specification backs the idea of a single point linestring (if I am interpreting it correctly). The OGC Document 99-049 (OpenGIS® Simple Features Specification For SQL Revision 1.1) does not seem to indicate that a 1 point linestring is invalid. The relevant sections are included below...

------------------------------------------
2.1.5 Curve
A Curve is a one-dimensional geometric object usually stored as a sequence of points, with the subtype of
Curve specifying the form of the interpolation between points. This specification defines only one subclass
of Curve, LineString, which uses linear interpolation between points.
Topologically a Curve is a one-dimensional geometric object that is the homeomorphic image of a real,
closed, interval D = [a, b] =

{x ∈ R  a <= x <= b}

under a mapping f:[a,b] → R2 as defined in [1],
section 3.12.7.2.
A Curve is simple if it does not pass through the same point twice ([1], section 3.12.7.3)
∀ c ∈ Curve, [a, b] = c.Domain,
c.IsSimple ⇔ ( ∀ x1, x2 ∈ (a, b] x1 ≠ x2 ⇒ f(x1) ≠ f (x2)) ∧ (∀ x1, x2 ∈ [a, b) x1 ≠ x2 ⇒ f(x1) ≠ f(x2))
A Curve is closed if its start point is equal to its end point. ([1], section 3.12.7.3)
The boundary of a closed Curve is empty.
A Curve that is simple and closed is a Ring.
The boundary of a non-closed Curve consists of its two end points. ([1], section 3.12.3.2).
A Curve is defined as topologically closed.

------------------------------------------
2.1.6 LineString, Line, LinearRing
A LineString is a Curve with linear interpolation between points. Each consecutive pair of points defines a
line segment.
A Line is a LineString with exactly 2 points.
A LinearRing is a LineString that is both closed and simple. The curve in Figure 2.2—(3) is a closed
LineString that is a LinearRing. The curve in Figure 2.2—(4) is a closed LineString that is not a
LinearRing.

Show
Tyler Erickson added a comment - I think the specification backs the idea of a single point linestring (if I am interpreting it correctly). The OGC Document 99-049 (OpenGIS® Simple Features Specification For SQL Revision 1.1) does not seem to indicate that a 1 point linestring is invalid. The relevant sections are included below... ------------------------------------------ 2.1.5 Curve A Curve is a one-dimensional geometric object usually stored as a sequence of points, with the subtype of Curve specifying the form of the interpolation between points. This specification defines only one subclass of Curve, LineString, which uses linear interpolation between points. Topologically a Curve is a one-dimensional geometric object that is the homeomorphic image of a real, closed, interval D = [a, b] = {x ∈ R  a <= x <= b} under a mapping f: [a,b] → R2 as defined in [1] , section 3.12.7.2. A Curve is simple if it does not pass through the same point twice ( [1] , section 3.12.7.3) ∀ c ∈ Curve, [a, b] = c.Domain, c.IsSimple ⇔ ( ∀ x1, x2 ∈ (a, b] x1 ≠ x2 ⇒ f(x1) ≠ f (x2)) ∧ (∀ x1, x2 ∈ [a, b) x1 ≠ x2 ⇒ f(x1) ≠ f(x2)) A Curve is closed if its start point is equal to its end point. ( [1] , section 3.12.7.3) The boundary of a closed Curve is empty. A Curve that is simple and closed is a Ring. The boundary of a non-closed Curve consists of its two end points. ( [1] , section 3.12.3.2). A Curve is defined as topologically closed. ------------------------------------------ 2.1.6 LineString, Line, LinearRing A LineString is a Curve with linear interpolation between points. Each consecutive pair of points defines a line segment. A Line is a LineString with exactly 2 points. A LinearRing is a LineString that is both closed and simple. The curve in Figure 2.2—(3) is a closed LineString that is a LinearRing. The curve in Figure 2.2—(4) is a closed LineString that is not a LinearRing.
Hide
Permalink
Benjamin Trigona-Harany added a comment -

This issue is still presenting itself when using a PostGIS store from GeoServer that contains single point lines. You can reproduce the issue by importing the ne_10m_roads shapefile from the Natural Earth dataset into PostGIS and then attempting to view the layer in GeoServer: the layer (and any layer group that includes the layer) will not render when the feature is inside the visible bounding box.

GeoServer: 2.2-SNAPSHOT (rev da48c93255c1f3ce4f7c47dbd27cbd14abd296e9)
GeoTools: 8-SNAPSHOT (rev b66372f14e505b645d4fa8f6769e942a65025c09)

Stack trace:

org.geoserver.platform.ServiceException: Rendering process failed
	at org.geoserver.wms.map.RenderedImageMapOutputFormat.produceMap(RenderedImageMapOutputFormat.java:516)
	at org.geoserver.wms.map.RenderedImageMapOutputFormat.produceMap(RenderedImageMapOutputFormat.java:254)
	at org.geoserver.wms.map.RenderedImageMapOutputFormat.produceMap(RenderedImageMapOutputFormat.java:126)
	at org.geoserver.wms.GetMap.executeInternal(GetMap.java:465)
	at org.geoserver.wms.GetMap.run(GetMap.java:201)
	at org.geoserver.wms.GetMap.run(GetMap.java:111)
	at org.geoserver.wms.DefaultWebMapService.getMap(DefaultWebMapService.java:353)
	at sun.reflect.GeneratedMethodAccessor183.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:318)
	at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183)
	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150)
	at org.geoserver.gwc.wms.CacheSeedingWebMapService.invoke(CacheSeedingWebMapService.java:61)
	at org.geoserver.gwc.wms.CacheSeedingWebMapService.invoke(CacheSeedingWebMapService.java:35)
	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
	at org.geoserver.gwc.wms.CachingWebMapService.invoke(CachingWebMapService.java:69)
	at org.geoserver.gwc.wms.CachingWebMapService.invoke(CachingWebMapService.java:50)
	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
	at org.geoserver.ows.util.RequestObjectLogger.invoke(RequestObjectLogger.java:54)
	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
	at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:202)
	at $Proxy21.getMap(Unknown Source)
	at sun.reflect.GeneratedMethodAccessor116.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.geoserver.ows.Dispatcher.execute(Dispatcher.java:772)
	at org.geoserver.ows.Dispatcher.handleRequestInternal(Dispatcher.java:272)
	at org.springframework.web.servlet.mvc.AbstractController.handleRequest(AbstractController.java:153)
	at org.springframework.web.servlet.mvc.SimpleControllerHandlerAdapter.handle(SimpleControllerHandlerAdapter.java:48)
	at org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:923)
	at org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:852)
	at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:882)
	at org.springframework.web.servlet.FrameworkServlet.doGet(FrameworkServlet.java:778)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:617)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
	at org.geoserver.filters.ThreadLocalsCleanupFilter.doFilter(ThreadLocalsCleanupFilter.java:23)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
	at org.geoserver.filters.SpringDelegatingFilter$Chain.doFilter(SpringDelegatingFilter.java:74)
	at org.geoserver.filters.SpringDelegatingFilter.doFilter(SpringDelegatingFilter.java:45)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
	at org.geoserver.platform.AdvancedDispatchFilter.doFilter(AdvancedDispatchFilter.java:49)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
	at org.vfny.geoserver.filters.SetCharacterEncodingFilter.doFilter(SetCharacterEncodingFilter.java:109)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:311)
	at org.geoserver.security.filter.GeoServerCompositeFilter$NestedFilterChain.doFilter(GeoServerCompositeFilter.java:68)
	at org.springframework.security.web.access.intercept.FilterSecurityInterceptor.invoke(FilterSecurityInterceptor.java:116)
	at org.springframework.security.web.access.intercept.FilterSecurityInterceptor.doFilter(FilterSecurityInterceptor.java:83)
	at org.geoserver.security.filter.GeoServerCompositeFilter$NestedFilterChain.doFilter(GeoServerCompositeFilter.java:72)
	at org.geoserver.security.filter.GeoServerCompositeFilter.doFilter(GeoServerCompositeFilter.java:91)
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:323)
	at org.geoserver.security.filter.GeoServerCompositeFilter$NestedFilterChain.doFilter(GeoServerCompositeFilter.java:68)
	at org.springframework.security.web.access.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:113)
	at org.geoserver.security.filter.GeoServerCompositeFilter$NestedFilterChain.doFilter(GeoServerCompositeFilter.java:72)
	at org.geoserver.security.filter.GeoServerCompositeFilter.doFilter(GeoServerCompositeFilter.java:91)
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:323)
	at org.geoserver.security.filter.GeoServerAnonymousAuthenticationFilter.doFilter(GeoServerAnonymousAuthenticationFilter.java:53)
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:323)
	at org.geoserver.security.filter.GeoServerCompositeFilter$NestedFilterChain.doFilter(GeoServerCompositeFilter.java:68)
	at org.springframework.security.web.authentication.www.BasicAuthenticationFilter.doFilter(BasicAuthenticationFilter.java:150)
	at org.geoserver.security.filter.GeoServerCompositeFilter$NestedFilterChain.doFilter(GeoServerCompositeFilter.java:72)
	at org.geoserver.security.filter.GeoServerCompositeFilter.doFilter(GeoServerCompositeFilter.java:91)
	at org.geoserver.security.filter.GeoServerBasicAuthenticationFilter.doFilter(GeoServerBasicAuthenticationFilter.java:82)
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:323)
	at org.geoserver.security.filter.GeoServerCompositeFilter$NestedFilterChain.doFilter(GeoServerCompositeFilter.java:68)
	at org.springframework.security.web.context.SecurityContextPersistenceFilter.doFilter(SecurityContextPersistenceFilter.java:87)
	at org.geoserver.security.filter.GeoServerCompositeFilter$NestedFilterChain.doFilter(GeoServerCompositeFilter.java:72)
	at org.geoserver.security.filter.GeoServerCompositeFilter.doFilter(GeoServerCompositeFilter.java:91)
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:323)
	at org.springframework.security.web.FilterChainProxy.doFilter(FilterChainProxy.java:173)
	at org.geoserver.security.GeoServerSecurityFilterChainProxy.doFilter(GeoServerSecurityFilterChainProxy.java:97)
	at org.springframework.web.filter.DelegatingFilterProxy.invokeDelegate(DelegatingFilterProxy.java:346)
	at org.springframework.web.filter.DelegatingFilterProxy.doFilter(DelegatingFilterProxy.java:259)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
	at org.geoserver.filters.LoggingFilter.doFilter(LoggingFilter.java:71)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
	at org.geoserver.filters.GZIPFilter.doFilter(GZIPFilter.java:41)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
	at org.geoserver.filters.SessionDebugFilter.doFilter(SessionDebugFilter.java:46)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
	at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
	at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
	at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
	at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
	at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
	at org.apache.catalina.ha.tcp.ReplicationValve.invoke(ReplicationValve.java:347)
	at org.apache.catalina.ha.session.JvmRouteBinderValve.invoke(JvmRouteBinderValve.java:227)
	at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:293)
	at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:859)
	at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:602)
	at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:489)
	at java.lang.Thread.run(Thread.java:662)
Caused by: java.lang.RuntimeException: org.geotools.data.DataSourceException: An exception occurred while parsing WKB data
	at org.geotools.jdbc.JDBCFeatureReader.next(JDBCFeatureReader.java:314)
	at org.geotools.jdbc.JDBCFeatureReader.next(JDBCFeatureReader.java:70)
	at org.geotools.data.store.ContentFeatureCollection$WrappingFeatureIterator.next(ContentFeatureCollection.java:218)
	at org.geotools.data.store.ContentFeatureCollection$WrappingFeatureIterator.next(ContentFeatureCollection.java:198)
	at org.geotools.data.crs.ForceCoordinateSystemIterator.next(ForceCoordinateSystemIterator.java:126)
	at org.geotools.data.crs.ForceCoordinateSystemIterator.next(ForceCoordinateSystemIterator.java:67)
	at org.geotools.renderer.lite.StreamingRenderer.drawPlain(StreamingRenderer.java:2510)
	at org.geotools.renderer.lite.StreamingRenderer.processStylers(StreamingRenderer.java:2012)
	at org.geotools.renderer.lite.StreamingRenderer.paint(StreamingRenderer.java:813)
	at org.geoserver.wms.map.RenderedImageMapOutputFormat.produceMap(RenderedImageMapOutputFormat.java:490)
	... 102 more
Caused by: org.geotools.data.DataSourceException: An exception occurred while parsing WKB data
	at org.geotools.data.postgis.WKBAttributeIO.wkb2Geometry(WKBAttributeIO.java:84)
	at org.geotools.data.postgis.WKBAttributeIO.read(WKBAttributeIO.java:112)
	at org.geotools.data.postgis.PostGISDialect.decodeGeometryValue(PostGISDialect.java:195)
	at org.geotools.jdbc.JDBCFeatureReader.next(JDBCFeatureReader.java:310)
	... 111 more
Caused by: java.lang.IllegalArgumentException: Invalid number of points in LineString (found 1 - must be 0 or >= 2)
	at com.vividsolutions.jts.geom.LineString.init(LineString.java:102)
	at com.vividsolutions.jts.geom.LineString.<init>(LineString.java:93)
	at com.vividsolutions.jts.geom.GeometryFactory.createLineString(GeometryFactory.java:496)
	at com.vividsolutions.jts.io.WKBReader.readLineString(WKBReader.java:227)
	at com.vividsolutions.jts.io.WKBReader.readGeometry(WKBReader.java:180)
	at com.vividsolutions.jts.io.WKBReader.readMultiLineString(WKBReader.java:269)
	at com.vividsolutions.jts.io.WKBReader.readGeometry(WKBReader.java:189)
	at com.vividsolutions.jts.io.WKBReader.read(WKBReader.java:144)
	at org.geotools.data.postgis.WKBAttributeIO.wkb2Geometry(WKBAttributeIO.java:82)
	... 114 more
Show
Benjamin Trigona-Harany added a comment - This issue is still presenting itself when using a PostGIS store from GeoServer that contains single point lines. You can reproduce the issue by importing the ne_10m_roads shapefile from the Natural Earth dataset into PostGIS and then attempting to view the layer in GeoServer: the layer (and any layer group that includes the layer) will not render when the feature is inside the visible bounding box. GeoServer: 2.2-SNAPSHOT (rev da48c93255c1f3ce4f7c47dbd27cbd14abd296e9) GeoTools: 8-SNAPSHOT (rev b66372f14e505b645d4fa8f6769e942a65025c09) Stack trace: org.geoserver.platform.ServiceException: Rendering process failed at org.geoserver.wms.map.RenderedImageMapOutputFormat.produceMap(RenderedImageMapOutputFormat.java:516) at org.geoserver.wms.map.RenderedImageMapOutputFormat.produceMap(RenderedImageMapOutputFormat.java:254) at org.geoserver.wms.map.RenderedImageMapOutputFormat.produceMap(RenderedImageMapOutputFormat.java:126) at org.geoserver.wms.GetMap.executeInternal(GetMap.java:465) at org.geoserver.wms.GetMap.run(GetMap.java:201) at org.geoserver.wms.GetMap.run(GetMap.java:111) at org.geoserver.wms.DefaultWebMapService.getMap(DefaultWebMapService.java:353) at sun.reflect.GeneratedMethodAccessor183.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:318) at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150) at org.geoserver.gwc.wms.CacheSeedingWebMapService.invoke(CacheSeedingWebMapService.java:61) at org.geoserver.gwc.wms.CacheSeedingWebMapService.invoke(CacheSeedingWebMapService.java:35) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172) at org.geoserver.gwc.wms.CachingWebMapService.invoke(CachingWebMapService.java:69) at org.geoserver.gwc.wms.CachingWebMapService.invoke(CachingWebMapService.java:50) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172) at org.geoserver.ows.util.RequestObjectLogger.invoke(RequestObjectLogger.java:54) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172) at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:202) at $Proxy21.getMap(Unknown Source) at sun.reflect.GeneratedMethodAccessor116.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.geoserver.ows.Dispatcher.execute(Dispatcher.java:772) at org.geoserver.ows.Dispatcher.handleRequestInternal(Dispatcher.java:272) at org.springframework.web.servlet.mvc.AbstractController.handleRequest(AbstractController.java:153) at org.springframework.web.servlet.mvc.SimpleControllerHandlerAdapter.handle(SimpleControllerHandlerAdapter.java:48) at org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:923) at org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:852) at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:882) at org.springframework.web.servlet.FrameworkServlet.doGet(FrameworkServlet.java:778) at javax.servlet.http.HttpServlet.service(HttpServlet.java:617) at javax.servlet.http.HttpServlet.service(HttpServlet.java:717) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) at org.geoserver.filters.ThreadLocalsCleanupFilter.doFilter(ThreadLocalsCleanupFilter.java:23) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) at org.geoserver.filters.SpringDelegatingFilter$Chain.doFilter(SpringDelegatingFilter.java:74) at org.geoserver.filters.SpringDelegatingFilter.doFilter(SpringDelegatingFilter.java:45) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) at org.geoserver.platform.AdvancedDispatchFilter.doFilter(AdvancedDispatchFilter.java:49) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) at org.vfny.geoserver.filters.SetCharacterEncodingFilter.doFilter(SetCharacterEncodingFilter.java:109) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:311) at org.geoserver.security.filter.GeoServerCompositeFilter$NestedFilterChain.doFilter(GeoServerCompositeFilter.java:68) at org.springframework.security.web.access.intercept.FilterSecurityInterceptor.invoke(FilterSecurityInterceptor.java:116) at org.springframework.security.web.access.intercept.FilterSecurityInterceptor.doFilter(FilterSecurityInterceptor.java:83) at org.geoserver.security.filter.GeoServerCompositeFilter$NestedFilterChain.doFilter(GeoServerCompositeFilter.java:72) at org.geoserver.security.filter.GeoServerCompositeFilter.doFilter(GeoServerCompositeFilter.java:91) at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:323) at org.geoserver.security.filter.GeoServerCompositeFilter$NestedFilterChain.doFilter(GeoServerCompositeFilter.java:68) at org.springframework.security.web.access.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:113) at org.geoserver.security.filter.GeoServerCompositeFilter$NestedFilterChain.doFilter(GeoServerCompositeFilter.java:72) at org.geoserver.security.filter.GeoServerCompositeFilter.doFilter(GeoServerCompositeFilter.java:91) at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:323) at org.geoserver.security.filter.GeoServerAnonymousAuthenticationFilter.doFilter(GeoServerAnonymousAuthenticationFilter.java:53) at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:323) at org.geoserver.security.filter.GeoServerCompositeFilter$NestedFilterChain.doFilter(GeoServerCompositeFilter.java:68) at org.springframework.security.web.authentication.www.BasicAuthenticationFilter.doFilter(BasicAuthenticationFilter.java:150) at org.geoserver.security.filter.GeoServerCompositeFilter$NestedFilterChain.doFilter(GeoServerCompositeFilter.java:72) at org.geoserver.security.filter.GeoServerCompositeFilter.doFilter(GeoServerCompositeFilter.java:91) at org.geoserver.security.filter.GeoServerBasicAuthenticationFilter.doFilter(GeoServerBasicAuthenticationFilter.java:82) at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:323) at org.geoserver.security.filter.GeoServerCompositeFilter$NestedFilterChain.doFilter(GeoServerCompositeFilter.java:68) at org.springframework.security.web.context.SecurityContextPersistenceFilter.doFilter(SecurityContextPersistenceFilter.java:87) at org.geoserver.security.filter.GeoServerCompositeFilter$NestedFilterChain.doFilter(GeoServerCompositeFilter.java:72) at org.geoserver.security.filter.GeoServerCompositeFilter.doFilter(GeoServerCompositeFilter.java:91) at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:323) at org.springframework.security.web.FilterChainProxy.doFilter(FilterChainProxy.java:173) at org.geoserver.security.GeoServerSecurityFilterChainProxy.doFilter(GeoServerSecurityFilterChainProxy.java:97) at org.springframework.web.filter.DelegatingFilterProxy.invokeDelegate(DelegatingFilterProxy.java:346) at org.springframework.web.filter.DelegatingFilterProxy.doFilter(DelegatingFilterProxy.java:259) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) at org.geoserver.filters.LoggingFilter.doFilter(LoggingFilter.java:71) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) at org.geoserver.filters.GZIPFilter.doFilter(GZIPFilter.java:41) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) at org.geoserver.filters.SessionDebugFilter.doFilter(SessionDebugFilter.java:46) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109) at org.apache.catalina.ha.tcp.ReplicationValve.invoke(ReplicationValve.java:347) at org.apache.catalina.ha.session.JvmRouteBinderValve.invoke(JvmRouteBinderValve.java:227) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:293) at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:859) at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:602) at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:489) at java.lang. Thread .run( Thread .java:662) Caused by: java.lang.RuntimeException: org.geotools.data.DataSourceException: An exception occurred while parsing WKB data at org.geotools.jdbc.JDBCFeatureReader.next(JDBCFeatureReader.java:314) at org.geotools.jdbc.JDBCFeatureReader.next(JDBCFeatureReader.java:70) at org.geotools.data.store.ContentFeatureCollection$WrappingFeatureIterator.next(ContentFeatureCollection.java:218) at org.geotools.data.store.ContentFeatureCollection$WrappingFeatureIterator.next(ContentFeatureCollection.java:198) at org.geotools.data.crs.ForceCoordinateSystemIterator.next(ForceCoordinateSystemIterator.java:126) at org.geotools.data.crs.ForceCoordinateSystemIterator.next(ForceCoordinateSystemIterator.java:67) at org.geotools.renderer.lite.StreamingRenderer.drawPlain(StreamingRenderer.java:2510) at org.geotools.renderer.lite.StreamingRenderer.processStylers(StreamingRenderer.java:2012) at org.geotools.renderer.lite.StreamingRenderer.paint(StreamingRenderer.java:813) at org.geoserver.wms.map.RenderedImageMapOutputFormat.produceMap(RenderedImageMapOutputFormat.java:490) ... 102 more Caused by: org.geotools.data.DataSourceException: An exception occurred while parsing WKB data at org.geotools.data.postgis.WKBAttributeIO.wkb2Geometry(WKBAttributeIO.java:84) at org.geotools.data.postgis.WKBAttributeIO.read(WKBAttributeIO.java:112) at org.geotools.data.postgis.PostGISDialect.decodeGeometryValue(PostGISDialect.java:195) at org.geotools.jdbc.JDBCFeatureReader.next(JDBCFeatureReader.java:310) ... 111 more Caused by: java.lang.IllegalArgumentException: Invalid number of points in LineString (found 1 - must be 0 or >= 2) at com.vividsolutions.jts.geom.LineString.init(LineString.java:102) at com.vividsolutions.jts.geom.LineString.<init>(LineString.java:93) at com.vividsolutions.jts.geom.GeometryFactory.createLineString(GeometryFactory.java:496) at com.vividsolutions.jts.io.WKBReader.readLineString(WKBReader.java:227) at com.vividsolutions.jts.io.WKBReader.readGeometry(WKBReader.java:180) at com.vividsolutions.jts.io.WKBReader.readMultiLineString(WKBReader.java:269) at com.vividsolutions.jts.io.WKBReader.readGeometry(WKBReader.java:189) at com.vividsolutions.jts.io.WKBReader.read(WKBReader.java:144) at org.geotools.data.postgis.WKBAttributeIO.wkb2Geometry(WKBAttributeIO.java:82) ... 114 more
Hide
Permalink
Andrea Aime added a comment -

Adding Martin Davis to the watchers, see if he has a perspective on this.

Show
Andrea Aime added a comment - Adding Martin Davis to the watchers, see if he has a perspective on this.
Hide
Permalink
Martin Davis added a comment -

Indeed I do...

It looks like the source of the problem lies in the JTS readers (WKBReader here, and WKTReader has the same issue). (And now that we're aware of it, it seems to be turning up all over the place, in other datasets as well as other JTS-based applications such as uDig.)

The simplest solution would be to fix the readers so that they handle one-point lines by simply adding a second identical point. I'm happy to do this - I think it's better for readers to be as accepting as possible, since it's hard to fix errors during read.

There's a similar issue with rings - they need to have 0 or >= 4 points to be structurally valid in JTS. The same kind of fix will apply here too. Of course, the "fixed" ring will be topologically invalid, but that's ok - it can always be checked for by some higher-level code if needed.

I'm on the verge of doing a 1.13 release, so I'll try and get the fix in before then. (It might also be nice to allow the readers to be set into a strict mode - but I'll leave that for a future release).

Show
Martin Davis added a comment - Indeed I do... It looks like the source of the problem lies in the JTS readers (WKBReader here, and WKTReader has the same issue). (And now that we're aware of it, it seems to be turning up all over the place, in other datasets as well as other JTS-based applications such as uDig.) The simplest solution would be to fix the readers so that they handle one-point lines by simply adding a second identical point. I'm happy to do this - I think it's better for readers to be as accepting as possible, since it's hard to fix errors during read. There's a similar issue with rings - they need to have 0 or >= 4 points to be structurally valid in JTS. The same kind of fix will apply here too. Of course, the "fixed" ring will be topologically invalid, but that's ok - it can always be checked for by some higher-level code if needed. I'm on the verge of doing a 1.13 release, so I'll try and get the fix in before then. (It might also be nice to allow the readers to be set into a strict mode - but I'll leave that for a future release).
Hide
Permalink
Martin Davis added a comment -

Ben has pointed out that this bug is pretty catastrophic in that it caused all rendering of the layer and layer group to fail completely.

Would it be worth hardening the data reading path to be more fault-tolerant during rendering?

Show
Martin Davis added a comment - Ben has pointed out that this bug is pretty catastrophic in that it caused all rendering of the layer and layer group to fail completely. Would it be worth hardening the data reading path to be more fault-tolerant during rendering?
Hide
Permalink
Andrea Aime added a comment -

Eh, this is strange, the renderer pulls in a feature at a time and only makes the rendering fail after a certain number of errors (1000 by default?)

Show
Andrea Aime added a comment - Eh, this is strange, the renderer pulls in a feature at a time and only makes the rendering fail after a certain number of errors (1000 by default?)
Hide
Permalink
Martin Davis added a comment -

By the way, I have fixed the WKBReader in JTS to avoid this single-point line problem, and I'll be releasing version 1.13 this week hopefully.

Show
Martin Davis added a comment - By the way, I have fixed the WKBReader in JTS to avoid this single-point line problem, and I'll be releasing version 1.13 this week hopefully.
Hide
Permalink
Benjamin Trigona-Harany added a comment -

The data set contained a total of 371 invalid (ie single point) lines. Prior to removing them, the layer did not render at all, but once they were removed, it rendered as expected.

Show
Benjamin Trigona-Harany added a comment - The data set contained a total of 371 invalid (ie single point) lines. Prior to removing them, the layer did not render at all, but once they were removed, it rendered as expected.
Hide
Permalink
Martin Davis added a comment -

JTS 1.13 is now released, with this fix.

Show
Martin Davis added a comment - JTS 1.13 is now released, with this fix.
Hide
Permalink
Martin Davis added a comment -

Should be fixed with inclusion of JTS 1.13

Show
Martin Davis added a comment - Should be fixed with inclusion of JTS 1.13
Hide
Permalink
Andrea Aime added a comment -

Updated the "fix for" version, the upgrade of JTS to 1.13 happened on trunk, but not on the stable series.

Show
Andrea Aime added a comment - Updated the "fix for" version, the upgrade of JTS to 1.13 happened on trunk, but not on the stable series.
Hide
Permalink
Andrea Aime added a comment -

Switching all issues that have been in "resolved" state for more than one month without further comments to "closed" status

Show
Andrea Aime added a comment - Switching all issues that have been in "resolved" state for more than one month without further comments to "closed" status

People

  • Assignee:
    Andrea Aime
    Reporter:
    Tyler Erickson
Vote (1)
Watch (4)

Dates

  • Created:
    Updated:
    Resolved: