added a comment -
[16:14] <aaime> that issue was one I opened in response to a user request
[16:14] <jdeolive> although OWS.getCharSet() might just be something we want to kill completely
[16:15] <aaime> that complained german chars are not properly encoded in geoserver 1.6 anymore
[16:15] <aaime> I looked in 1.5.x
[16:15] <aaime> and there is plenty of places that do use GeoServer.getCharset()
[16:15] <aaime> we should reinstate all the previous charset settings
[16:15] <aaime> how you do that it's your business
[16:16] <aaime> but you have to make sure every xml encoder
[16:16] <aaime> receives the proper charset
[16:16] <aaime> at the momet we have one case where ows.getCharset is called
[16:16] <aaime> and your fix is as good as any
[16:16] <aaime> but there are other places where the charset was set in 1.5.x
[16:16] <aaime> and it's not anymore today
[16:17] <aaime> so the fix is not only to reroute that ows.gecharset call
[16:17] <aaime> but also to do a similar encoder.setCharset call
[16:17] <aaime> in every other gs services
[16:17] <aaime> that does output xml
[16:17] <aaime> (done)
[16:17] <aaime> looking for that mail
[16:18] <groldan> in a word it is to make sure all xml responses use GeoServer.getCharset() as the encoding scheme?
[16:18] <aaime> yep
[16:18] <groldan> ok, thanks
[16:18] <aaime> which is mechanical, but not exactly a 5 minutes one
Bug
Closed
Major
[16:14] <aaime> that issue was one I opened in response to a user request
[16:14] <jdeolive> although OWS.getCharSet() might just be something we want to kill completely
[16:15] <aaime> that complained german chars are not properly encoded in geoserver 1.6 anymore
[16:15] <aaime> I looked in 1.5.x
[16:15] <aaime> and there is plenty of places that do use GeoServer.getCharset()
[16:15] <aaime> we should reinstate all the previous charset settings
[16:15] <aaime> how you do that it's your business
[16:16] <aaime> but you have to make sure every xml encoder
[16:16] <aaime> receives the proper charset
[16:16] <aaime> at the momet we have one case where ows.getCharset is called
[16:16] <aaime> and your fix is as good as any
[16:16] <aaime> but there are other places where the charset was set in 1.5.x
[16:16] <aaime> and it's not anymore today
[16:17] <aaime> so the fix is not only to reroute that ows.gecharset call
[16:17] <aaime> but also to do a similar encoder.setCharset call
[16:17] <aaime> in every other gs services
[16:17] <aaime> that does output xml
[16:17] <aaime> (done)
[16:17] <aaime> looking for that mail
[16:18] <groldan> in a word it is to make sure all xml responses use GeoServer.getCharset() as the encoding scheme?
[16:18] <aaime> yep
[16:18] <groldan> ok, thanks
[16:18] <aaime> which is mechanical, but not exactly a 5 minutes one