GeoServer

Label mixed syntax loses newlines

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.6.0-RC2
  • Fix Version/s: 1.7.3
  • Component/s: WMS
  • Labels:
    None
  • Number of attachments :
    0

Description

When parsing mixed syntax such as:

<!-- a text symbolizer for tasmania states -->
<TextSymbolizer>
  <Label><ogc:PropertyName>STATE</ogc:PropertyName> &#10; <ogc:PropertyName>COUNTRY</ogc:PropertyName></Label>
  <Font>
    <CssParameter name="font-family">Arial</CssParameter>
    <CssParameter name="font-style">Normal</CssParameter>
    <CssParameter name="font-size">12</CssParameter>
  </Font>
  <Fill>
    <CssParameter name="fill">#000000</CssParameter>
  </Fill>
</TextSymbolizer>

the newline entity ( ) is discarded by ExpressionDomParser.parse(Literar element). We need a way to tell the expression dom parser not to trim the literals in that case.

Issue Links

depends upon

Bug - A problem which impairs or prevents the functions of the product. GEOS-1620 SLD parser trims whitespaces from literals

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Improvement - An improvement or enhancement to an existing feature or task. GEOT-1996 Add CDATA section parsing to SLD Labels and allow labels to be rendered as multiline if they contain newline characters

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Improvement - An improvement or enhancement to an existing feature or task. GEOT-2323 SLDParser does not respect standard whitespace handling in mixed content sections

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Andrea Aime added a comment -

This one seems to be related to the whitespace trimming reported in GEOS-1620

Show
Andrea Aime added a comment - This one seems to be related to the whitespace trimming reported in GEOS-1620
Hide
Permalink
Gabriel Roldan added a comment -

scheduling for 1.7.1, the changes needed in label rendering gives us no time to reach 1.6.5

Show
Gabriel Roldan added a comment - scheduling for 1.7.1, the changes needed in label rendering gives us no time to reach 1.6.5
Hide
Permalink
Andrea Aime added a comment -

Due to the white space handling rule declared in the SLD xml schema there is no way any direct newline can survive a parse conforming to the schema, the rule says all white space must be smashed into a single whitespace char (no matter if it's at the beginning, the end, or in the middle of the sentence).
The solution for this would be to define a newLine() filter function that can be called withing the Label, that would survive. Maybe even a CDATA section could, I'm not sure.

Show
Andrea Aime added a comment - Due to the white space handling rule declared in the SLD xml schema there is no way any direct newline can survive a parse conforming to the schema, the rule says all white space must be smashed into a single whitespace char (no matter if it's at the beginning, the end, or in the middle of the sentence). The solution for this would be to define a newLine() filter function that can be called withing the Label, that would survive. Maybe even a CDATA section could, I'm not sure.
Hide
Permalink
Andrea Aime added a comment -

And oh, btw, the new labeller we'll start releasing with 1.7.2 as an option (but disabled by default) will know how to paint multiline labels and will also automatically wrap too long text based on a vendorOption the user can specify.

Show
Andrea Aime added a comment - And oh, btw, the new labeller we'll start releasing with 1.7.2 as an option (but disabled by default) will know how to paint multiline labels and will also automatically wrap too long text based on a vendorOption the user can specify.
Hide
Permalink
Gabriel Roldan added a comment -

A CDATA section works just well. I checked the correct string with all whitespaces and newlines and whatever you put on it is correctly parsed as a literal expression and the mixed syntax parsed as a compound expression giving the desired string out of a mixture of literals and property names up to the point when it needs to be rendered

Show
Gabriel Roldan added a comment - A CDATA section works just well. I checked the correct string with all whitespaces and newlines and whatever you put on it is correctly parsed as a literal expression and the mixed syntax parsed as a compound expression giving the desired string out of a mixture of literals and property names up to the point when it needs to be rendered
Hide
Permalink
Andrea Aime added a comment -

Fixed on 1.7.x

Show
Andrea Aime added a comment - Fixed on 1.7.x

People

  • Assignee:
    Andrea Aime
    Reporter:
    Andrea Aime
Vote (1)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: