GeoServer
  1. GeoServer
  2. GEOS-1094

XML Transformer factory is being set by System.setProperty, impacting entire JVM, breaking Weblogic 9.x

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 1.7.5, 1.7.6, 2.0-beta2, 2.0.x
    • Fix Version/s: 2.0.1
    • Component/s: WFS
    • Labels:
      None
    • Environment:
      Weblogic 9.X, Tomcat 5.5, Tomcat 6, JDK 1.5
    • Number of attachments :
      1

      Description

      In wfs/src/main/java/org/geoserver/wfs/xml/GML2OutputFormat.java on line 144-145 the XML Transformer factory is being set System wide via System.setProperty(...). Because this property is set JVM wide it cripples Weblogic's Admin capabilities (even startup and shutdown) since it tries to instantiate the TransformerFactory when it doesn't have the specific TransformerFactory class in its classpath.

        Activity

        Hide
        Ben Caradoc-Davies added a comment -

        Subject: Re: [Geoserver-devel] Xalan TransformerFactory system property change
        Date: Thu, 23 Jul 2009 10:08:45 +0800
        From: Justin Deoliveira
        To: Caradoc-Davies, Ben (E&M, Kensington)
        CC: Geoserver-devel, Andrea Aime
        References: <4A66BDE1.8000607@csiro.au>

        Thankfully this time something XML related is not my fault . I am not
        sure why that line is there... but +1 on removing it. It would be good
        if we could verify that it does not break anything, testing cite in a
        servlet container and in jetty.

        Ben Caradoc-Davies wrote:
        > Justin,
        >
        > is there any reason why we should not get rid of a troublesome Xalan
        > System.setProperty in GML2OutputFormat?
        > http://jira.codehaus.org/browse/GEOS-1094
        >
        > Kind regards,
        >


        Justin Deoliveira
        OpenGeo - http://opengeo.org
        Enterprise support for open source geospatial.

        Show
        Ben Caradoc-Davies added a comment - Subject: Re: [Geoserver-devel] Xalan TransformerFactory system property change Date: Thu, 23 Jul 2009 10:08:45 +0800 From: Justin Deoliveira To: Caradoc-Davies, Ben (E&M, Kensington) CC: Geoserver-devel, Andrea Aime References: <4A66BDE1.8000607@csiro.au> Thankfully this time something XML related is not my fault . I am not sure why that line is there... but +1 on removing it. It would be good if we could verify that it does not break anything, testing cite in a servlet container and in jetty. Ben Caradoc-Davies wrote: > Justin, > > is there any reason why we should not get rid of a troublesome Xalan > System.setProperty in GML2OutputFormat? > http://jira.codehaus.org/browse/GEOS-1094 > > Kind regards, > – Justin Deoliveira OpenGeo - http://opengeo.org Enterprise support for open source geospatial.
        Hide
        Andrea Aime added a comment -

        With Justin we agreed that the change is too close to the release and thus we won't apply it for 1.7.6
        But we'll apply it on trunk and see how it plays.

        Show
        Andrea Aime added a comment - With Justin we agreed that the change is too close to the release and thus we won't apply it for 1.7.6 But we'll apply it on trunk and see how it plays.
        Hide
        Sebastien Deleuze added a comment -

        Could you apply it on 1.7.x branch please ?

        Show
        Sebastien Deleuze added a comment - Could you apply it on 1.7.x branch please ?
        Hide
        Andrea Aime added a comment -

        Bouiaw, the 1.7.x series is dead, we won't make releases unless there is specific funding to do so. But you can still checkout the soruces, apply the patch youself and build GeoServer

        Show
        Andrea Aime added a comment - Bouiaw, the 1.7.x series is dead, we won't make releases unless there is specific funding to do so. But you can still checkout the soruces, apply the patch youself and build GeoServer
        Hide
        Ben Caradoc-Davies added a comment -

        Note that this patch was applied on trunk in r12942 by Andrea, fixing 2.0.x and later.

        Show
        Ben Caradoc-Davies added a comment - Note that this patch was applied on trunk in r12942 by Andrea, fixing 2.0.x and later.

          People

          • Assignee:
            Andrea Aime
            Reporter:
            Matt Aizcorbe
          • Votes:
            2 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: