GeoServer
  1. GeoServer
  2. GEOS-1067

Add antialias control in both WMS calls and configuration

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.5.0
    • Fix Version/s: None
    • Component/s: WMS
    • Labels:
      None
    • Number of attachments :
      0

      Description

      Enabling antialias is something that goes beyond the format,
      can be useful in all formats if you need sheer speed.
      Maybe we should add another vendor parameter?
      ...&antialias=FULL/TEXT/GEOM/NONE

      We could also provide the same kind of setting as a global WMS hint (that one we have now works only for PDF and it's misleading).

        Issue Links

          Activity

          Hide
          Andrea Aime added a comment -

          I've added you as watchers to discuss this a bit.

          This can be handled as suggested by the first comment, that is, with a standalone antialias parameter, or with the new format_options machinery.

          Pro and cons of "antialias":

          • can be done on 1.5.x too
          • adds a general parameter that does not make sense for some WMS output formats (KML, RSS)

          Pro and cons of format_options=antialias:full/text/geom:

          • cannot be done on 1.5.x, we don't have the format_options mini framework (it's only on trunk)
          • makes it explicit that some formats won't really handle antialias

          On the other hand, if we add antialiasing settings to the configuration as well, it ends up being something global anyways. Hard choice. Suggestions?

          Show
          Andrea Aime added a comment - I've added you as watchers to discuss this a bit. This can be handled as suggested by the first comment, that is, with a standalone antialias parameter, or with the new format_options machinery. Pro and cons of "antialias": can be done on 1.5.x too adds a general parameter that does not make sense for some WMS output formats (KML, RSS) Pro and cons of format_options=antialias:full/text/geom: cannot be done on 1.5.x, we don't have the format_options mini framework (it's only on trunk) makes it explicit that some formats won't really handle antialias On the other hand, if we add antialiasing settings to the configuration as well, it ends up being something global anyways. Hard choice. Suggestions?
          Hide
          Andrea Aime added a comment -

          Bringing in Saul too. I noticed that in fact Saul added code to 1.5.x to handle format_options like formats and used that for legend graphics call, where the call can be something like:
          http://.../wms?request=GetLegendGraphics&...&legendOptions=fontAntiAliasing:on;forceLabels=on

          Now, this clearly is similar to what we want to do here with GetMap antialiasing, and with the eventual global configuration param too.
          I would like consistency between the two, and also have the global params influence GetLegendGraphics as well.

          Saul, are we still in time to change the legendOptions so that instead of having fontAntialiasing, we have just "antialias", with possible values full/text/off?
          (this would leave off the option to have graphics antialiased but not text, which is possible in legend graphics but not in GetMap due to implementation differences).

          Show
          Andrea Aime added a comment - Bringing in Saul too. I noticed that in fact Saul added code to 1.5.x to handle format_options like formats and used that for legend graphics call, where the call can be something like: http://.../wms?request=GetLegendGraphics&...&legendOptions=fontAntiAliasing:on;forceLabels=on Now, this clearly is similar to what we want to do here with GetMap antialiasing, and with the eventual global configuration param too. I would like consistency between the two, and also have the global params influence GetLegendGraphics as well. Saul, are we still in time to change the legendOptions so that instead of having fontAntialiasing, we have just "antialias", with possible values full/text/off? (this would leave off the option to have graphics antialiased but not text, which is possible in legend graphics but not in GetMap due to implementation differences).
          Hide
          Chris Holmes added a comment -

          Let's just do it on 1.6.0-beta3, with the formatoptions.

          Show
          Chris Holmes added a comment - Let's just do it on 1.6.0-beta3, with the formatoptions.
          Hide
          Saul Farber added a comment -

          Andrea: your suggestion makes perfect sense to me. +1 for an extra 'format_options' keys and for having getLegendGraphic use the format_options parameter.

          Looking at my docs page (http://docs.codehaus.org/display/GEOSDEV/GetLegendGraphic+Improvements), does getLegendGraphic currently use format_options, or 'LEGEND_OPTIONS'?

          In any case, having getLegendGraphic use FORMAT_OPTIONS and having the 'antialias' key respect full/text/off values is a great idea in my book.

          Show
          Saul Farber added a comment - Andrea: your suggestion makes perfect sense to me. +1 for an extra 'format_options' keys and for having getLegendGraphic use the format_options parameter. Looking at my docs page ( http://docs.codehaus.org/display/GEOSDEV/GetLegendGraphic+Improvements ), does getLegendGraphic currently use format_options, or 'LEGEND_OPTIONS'? In any case, having getLegendGraphic use FORMAT_OPTIONS and having the 'antialias' key respect full/text/off values is a great idea in my book.
          Hide
          Andrea Aime added a comment -

          It uses LEGEND_OPTIONS.
          Given that this has been moved to 1.6.0, by making them uniform we'll break eventual clients that adopted the current 1.5.x request format (I mean, antialiasing control will change from fontoAntiAliasing=on to antialias=text).

          Not a big deal if we don't advertise too much the LEGEND_OPTIONS :-p

          Show
          Andrea Aime added a comment - It uses LEGEND_OPTIONS. Given that this has been moved to 1.6.0, by making them uniform we'll break eventual clients that adopted the current 1.5.x request format (I mean, antialiasing control will change from fontoAntiAliasing=on to antialias=text). Not a big deal if we don't advertise too much the LEGEND_OPTIONS :-p
          Hide
          Andrea Aime added a comment -

          We have the option to disable antialiasing in the call. Non antialiased rendering is so old century, so I don't see us adding antialiasing control in the config anytime soon

          Show
          Andrea Aime added a comment - We have the option to disable antialiasing in the call. Non antialiased rendering is so old century, so I don't see us adding antialiasing control in the config anytime soon
          Hide
          Andrea Aime added a comment -

          Bulk closing all resolved issue that have not gotten any more feedback or comment in the last month

          Show
          Andrea Aime added a comment - Bulk closing all resolved issue that have not gotten any more feedback or comment in the last month

            People

            • Assignee:
              Andrea Aime
              Reporter:
              Andrea Aime
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: