GeoAPI

Use FeatureId as Feature Indentifier

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.1-M4
  • Fix Version/s: 2.2-M1
  • Component/s: feature
  • Labels:
    None
  • Number of attachments :
    0

Description

The idea of Identity is currently captured as a String; this can be improved on in two ways:

  • strong typing for clarity
  • bring in line with use of Identifier / FeatureId / GMLObjectId etc from Filter packages

As noted in linked GeoTools bug - String is not always sufficient; indeed when mocing into versioned data it is likely a compound Identifier will be needed based on ID and VERSION.

Issue Links

supercedes

Improvement - An improvement or enhancement to an existing feature or task. GEOT-148 Create FID interface

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Jody Garnett made changes -
Field Original Value New Value
Link This issue supercedes GEOT-148 [ GEOT-148 ]
Hide
Permalink
Jody Garnett added a comment -

The filter interface Identity (and subclass FeatureId) represent the solution to this request - all that remains is ensuring their intergration with the Feature Model.

Show
Jody Garnett added a comment - The filter interface Identity (and subclass FeatureId) represent the solution to this request - all that remains is ensuring their intergration with the Feature Model.
Jody Garnett made changes -
Fix Version/s 2.1-M4 [ 11866 ]
Fix Version/s 2.1 [ 13446 ]
Jody Garnett made changes -
Fix Version/s 2.1 [ 13678 ]
Fix Version/s 2.1-M7 [ 13446 ]
Jody Garnett made changes -
Fix Version/s 2.1-M8 [ 13678 ]
Fix Version/s 2.1 [ 13697 ]
Martin Desruisseaux made changes -
Fix Version/s 2.1 [ 13697 ]
Fix Version/s 2.2 [ 12386 ]
Hide
Permalink
Jody Garnett added a comment -

I am going ahead with this fix:

  • Attribute.getIdentifier(): Identifier<String>
  • Feature.getIdentifier(): FeatureId
  • SimpleFeature.getId(): String documented as being the same as getIdentifier().getID();

I have also changed the generics for Identifier to only document what is needful; this simple reflects more experience with the Java syntax rather than any change of meaning.

Show
Jody Garnett added a comment - I am going ahead with this fix: Attribute.getIdentifier(): Identifier<String> Feature.getIdentifier(): FeatureId SimpleFeature.getId(): String documented as being the same as getIdentifier().getID(); I have also changed the generics for Identifier to only document what is needful; this simple reflects more experience with the Java syntax rather than any change of meaning.
Hide
Permalink
Jody Garnett added a comment -

Committed revision 1279.

Show
Jody Garnett added a comment - Committed revision 1279.
Jody Garnett made changes -
Resolution Fixed [ 1 ]
Status Open [ 1 ] Closed [ 6 ]
Martin Desruisseaux made changes -
Resolution Fixed [ 1 ]
Assignee Jody Garnett [ jgarnett ]
Status Closed [ 6 ] Reopened [ 4 ]
Martin Desruisseaux made changes -
Fix Version/s 2.2 [ 12386 ]
Fix Version/s 2.2-M1 [ 14472 ]
Resolution Fixed [ 1 ]
Status Reopened [ 4 ] Closed [ 6 ]

People

  • Assignee:
    Jody Garnett
    Reporter:
    Jody Garnett
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: