GeoAPI
  1. GeoAPI
  2. GEO-91

Use FeatureId as Feature Indentifier

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1-M4
    • Fix Version/s: 2.2-M1
    • Component/s: feature
    • Labels:
      None
    • Number of attachments :
      0

      Description

      The idea of Identity is currently captured as a String; this can be improved on in two ways:

      • strong typing for clarity
      • bring in line with use of Identifier / FeatureId / GMLObjectId etc from Filter packages

      As noted in linked GeoTools bug - String is not always sufficient; indeed when mocing into versioned data it is likely a compound Identifier will be needed based on ID and VERSION.

        Issue Links

          Activity

          Hide
          Jody Garnett added a comment -

          The filter interface Identity (and subclass FeatureId) represent the solution to this request - all that remains is ensuring their intergration with the Feature Model.

          Show
          Jody Garnett added a comment - The filter interface Identity (and subclass FeatureId) represent the solution to this request - all that remains is ensuring their intergration with the Feature Model.
          Hide
          Jody Garnett added a comment -

          I am going ahead with this fix:

          • Attribute.getIdentifier(): Identifier<String>
          • Feature.getIdentifier(): FeatureId
          • SimpleFeature.getId(): String documented as being the same as getIdentifier().getID();

          I have also changed the generics for Identifier to only document what is needful; this simple reflects more experience with the Java syntax rather than any change of meaning.

          Show
          Jody Garnett added a comment - I am going ahead with this fix: Attribute.getIdentifier(): Identifier<String> Feature.getIdentifier(): FeatureId SimpleFeature.getId(): String documented as being the same as getIdentifier().getID(); I have also changed the generics for Identifier to only document what is needful; this simple reflects more experience with the Java syntax rather than any change of meaning.
          Hide
          Jody Garnett added a comment -

          Committed revision 1279.

          Show
          Jody Garnett added a comment - Committed revision 1279.

            People

            • Assignee:
              Jody Garnett
              Reporter:
              Jody Garnett
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: