GeoAPI

MathTransformFactory.createPassThroughTransform(...) should expect a int[] argument

Details

  • Type: Improvement Improvement
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 2.0
  • Fix Version/s: None
  • Component/s: referencing
  • Labels:
  • Number of attachments :
    0

Description

Current signature of MathTransformFactory.createPassThroughTransform(...) is:

(int firstAffectedOrdinate, MathTransform subTransform, int numTrailingOrdinates)

it should be something like:

(int[] modifiedOrdinates, MathTransform subTransform)

in order to match PassThroughOperation.getModifiedOrdinates() API (derived from ISO 19111).

Activity

Ascending order - Click to sort in descending order
Martin Desruisseaux made changes -
Field Original Value New Value
Component/s referencing [ 11092 ]
Environment
Description Current signature of MathTransformFactory.createPassThroughTransform(...) is:


    (int firstAffectedOrdinate, MathTransform subTransform, int numTrailingOrdinates)


it should be something like:


    (int[] modifiedOrdinates, MathTransform subTransform)


in order to match PassThroughOperation.getModifiedOrdinates() API (derived from ISO 19111). 		Current signature of MathTransformFactory.createPassThroughTransform(...) is:


    (int firstAffectedOrdinate, MathTransform subTransform, int numTrailingOrdinates)


it should be something like:


    (int[] modifiedOrdinates, MathTransform subTransform)


in order to match PassThroughOperation.getModifiedOrdinates() API (derived from ISO 19111).
Martin Desruisseaux made changes -
Environment
Fix Version/s 2.2 [ 11866 ]
Description Current signature of MathTransformFactory.createPassThroughTransform(...) is:


    (int firstAffectedOrdinate, MathTransform subTransform, int numTrailingOrdinates)


it should be something like:


    (int[] modifiedOrdinates, MathTransform subTransform)


in order to match PassThroughOperation.getModifiedOrdinates() API (derived from ISO 19111). 		Current signature of MathTransformFactory.createPassThroughTransform(...) is:


    (int firstAffectedOrdinate, MathTransform subTransform, int numTrailingOrdinates)


it should be something like:


    (int[] modifiedOrdinates, MathTransform subTransform)


in order to match PassThroughOperation.getModifiedOrdinates() API (derived from ISO 19111).
Martin Desruisseaux made changes -
Assignee Martin Desruisseaux [ desruisseaux ]
Martin Desruisseaux made changes -
Link This issue is related to GEO-76 [ GEO-76 ]
Jody Garnett made changes -
Fix Version/s 2.1 [ 13446 ]
Fix Version/s 2.1-M4 [ 11866 ]
Jody Garnett made changes -
Fix Version/s 2.1 [ 13678 ]
Fix Version/s 2.1-M7 [ 13446 ]
Jody Garnett made changes -
Fix Version/s 2.1 [ 13697 ]
Fix Version/s 2.1-M8 [ 13678 ]
Martin Desruisseaux made changes -
Issue Type Bug [ 1 ] Sub-task [ 7 ]
Parent GEO-76 [ 33875 ]
Martin Desruisseaux made changes -
Link This issue is related to GEO-76 [ GEO-76 ]
Martin Desruisseaux made changes -
Fix Version/s 2.1 [ 13697 ]
Description Current signature of MathTransformFactory.createPassThroughTransform(...) is:


    (int firstAffectedOrdinate, MathTransform subTransform, int numTrailingOrdinates)


it should be something like:


    (int[] modifiedOrdinates, MathTransform subTransform)


in order to match PassThroughOperation.getModifiedOrdinates() API (derived from ISO 19111). 		Current signature of MathTransformFactory.createPassThroughTransform(...) is:

{code:none}
(int firstAffectedOrdinate, MathTransform subTransform, int numTrailingOrdinates)
{code}

it should be something like:

{code:none}
(int[] modifiedOrdinates, MathTransform subTransform)
{code}

in order to match PassThroughOperation.getModifiedOrdinates() API (derived from ISO 19111).
Hide
Permalink
Martin Desruisseaux added a comment -

Needs one more parameter for specifying the number of input dimensions, which can not be inferred from the sub transform. In addition the modifiedOrdinates array length must match the subTransform input dimensions.

Uncommiting from 2.1 since the above make the API slightly less intuitive and I'm not sure there is a need for that.

Show
Martin Desruisseaux added a comment - Needs one more parameter for specifying the number of input dimensions, which can not be inferred from the sub transform. In addition the modifiedOrdinates array length must match the subTransform input dimensions. Uncommiting from 2.1 since the above make the API slightly less intuitive and I'm not sure there is a need for that.
Hide
Permalink
Martin Desruisseaux added a comment -

This change request was documented in section 6.2 of "GeoAPI specifics" RFC submitted to OGC at Paris. We are removing it from the RFC to be posted before the OGC meeting in Italy. It may be copied back in a future RFC.

Show
Martin Desruisseaux added a comment - This change request was documented in section 6.2 of "GeoAPI specifics" RFC submitted to OGC at Paris. We are removing it from the RFC to be posted before the OGC meeting in Italy. It may be copied back in a future RFC.
Martin Desruisseaux made changes -
Issue Type Sub-task [ 7 ] Improvement [ 4 ]
Parent GEO-76 [ 33875 ]
Martin Desruisseaux made changes -
Labels Factory

People

  • Assignee:
    Martin Desruisseaux
    Reporter:
    Martin Desruisseaux
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:

Time Tracking

Estimated:
15m
Original Estimate - 15 minutes
Remaining:
15m
Remaining Estimate - 15 minutes
Logged:
Not Specified
Time Spent - Not Specified