GeoAPI
  1. GeoAPI
  2. GEO-47

Remove createProjectedCRS(Map,GeographicCRS,ParameterValueGroup,CartesianCS)

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: referencing
    • Labels:
      None
    • Number of attachments :
      0

      Description

      The following methods should be removed from CRSFactory interface:

      • createProjectedCRS(Map, GeographicCRS, String, GeneralParameterValue[], CartesianCS);
      • createProjectedCRS(Map, GeographicCRS, ParameterValueGroup, CartesianCS);
      • getDefaultParameters();

      The following method will stay there:

      • createProjectedCRS(Map, OperationMethod, GeographicCRS, MathTransform, CartesianCS);

      Basically, this bug report is about removing any method from CRSFactory that try to creates themself a MathTransform, for the following reasons:

      • It introduces a dependency to MathTransformFactory at the
        implementation level of this method. This is against the
        orthogonal aspect of factories (no other methods force this
        kind of cross-dependency).
      • It brings duplication with MathTransformFactory's API,
        e.g. getDefaultParameters().
      • This is mostly a convenience method; user can do the same with
        similar efficiency in their own code.
      • Experience gained in Geotoosl implementation and usage suggests
        that it is hard to get a method that meets every need. Some code
        will ignore this method and build ProjectedCRS in their own way
        (with the createProjectedCRS(..., MathTransform, ...) method)
        anyway. They may want to use their own MathTransformFactory, use
        a different OperationMethod, etc.

      If there is some voice against the removal of all 'createProjectedCRS(...)' methods without explicit MathTransform parameter, please comment here.

        Issue Links

          Activity

          Hide
          Martin Desruisseaux added a comment -

          Those methods has not been deprecated in latest GeoAPI snapshot. They will be removed later (unless some peoples express objections).

          Show
          Martin Desruisseaux added a comment - Those methods has not been deprecated in latest GeoAPI snapshot. They will be removed later (unless some peoples express objections).
          Hide
          Martin Desruisseaux added a comment -

          A last remaining deprecated method need to be removed in a post-1.1 release.

          Show
          Martin Desruisseaux added a comment - A last remaining deprecated method need to be removed in a post-1.1 release.

            People

            • Assignee:
              Martin Desruisseaux
              Reporter:
              Martin Desruisseaux
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: