Geb

Add waiting, window closing and page switching options to withNewWindow()

Details

  • Type: Improvement Improvement
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 0.6.2
  • Fix Version/s: 0.9.0
  • Component/s: Core
  • Labels:
    None
  • Number of attachments :
    0

Description

And also throw an own exception when no window has been opened, now it looks like web driver is throwing the exception which is not the case.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
John Murph added a comment -

Just a comment on the page switching options. On the mailing list, Luke suggested this syntax:

withNewWindow(

{ /* opening action */}

, page: SomePage) {}

Also, after the window closure (the body) returns the context should be automatically switched back to the calling context.

Show
John Murph added a comment - Just a comment on the page switching options. On the mailing list, Luke suggested this syntax: withNewWindow( { /* opening action */} , page: SomePage) {} Also, after the window closure (the body) returns the context should be automatically switched back to the calling context.
Hide
Permalink
Marcin Erdmann added a comment -

Fixed in https://github.com/geb/geb/commit/574922179026e003ff382a8fbe4c4a7ab6edd8c8

Show
Marcin Erdmann added a comment - Fixed in https://github.com/geb/geb/commit/574922179026e003ff382a8fbe4c4a7ab6edd8c8

People

  • Assignee:
    Marcin Erdmann
    Reporter:
    Marcin Erdmann
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: