Geb

.text() does not perform as expected

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Not A Bug
  • Affects Version/s: 0.6.2
  • Fix Version/s: 0.7.0
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    0

Description

When text() is called on a jQuery object the text from all the selected elements is returned concatenated together. For example, with this HTML:
<div class="foo">a</div>
<div class="bar">b</div>
<div class="foo">c</div>
This JavaScript `$('.foo').text()` would return 'ab'. However, this does not work as such with Geb.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Matt Follett added a comment -

Oops, that is incorrect, it would be 'ac'.

Show
Matt Follett added a comment - Oops, that is incorrect, it would be 'ac'.
Hide
Permalink
Luke Daley added a comment -

Thanks for the report, we'll change it to return the text of the first match.

Show
Luke Daley added a comment - Thanks for the report, we'll change it to return the text of the first match.
Hide
Permalink
Matt Follett added a comment -

No, it should be returning the text of all the matches concatenated together if it is suppose to be like jQuery.

Show
Matt Follett added a comment - No, it should be returning the text of all the matches concatenated together if it is suppose to be like jQuery.
Hide
Permalink
Luke Daley added a comment -

Returning the first is more flexible, because if you want all the text you can use the spread operator.

$("div.foo").text() == "a"
$("div.foo")*.text() == ["a", "c"]

Because we have the convenience of the spread operator, it makes sense to deviate here.

Show
Luke Daley added a comment - Returning the first is more flexible, because if you want all the text you can use the spread operator. $( "div.foo" ).text() == "a" $( "div.foo" )*.text() == [ "a" , "c" ] Because we have the convenience of the spread operator, it makes sense to deviate here.
Hide
Permalink
Matt Follett added a comment -

That's true, though I'd think there'd be value in consistency between the two. Either way sounds good, but if you just return the first string it might be good to mention the difference in the docs.

Show
Matt Follett added a comment - That's true, though I'd think there'd be value in consistency between the two. Either way sounds good, but if you just return the first string it might be good to mention the difference in the docs.
Hide
Permalink
Luke Daley added a comment -

It will definitely be in the docs. Cheers.

Show
Luke Daley added a comment - It will definitely be in the docs. Cheers.
Hide
Permalink
Marcin Erdmann added a comment -

This is working as described in the manual:
http://www.gebish.org/manual/current/navigator.html#accessing_tag_name_attributes_text_and_classes

Show
Marcin Erdmann added a comment - This is working as described in the manual: http://www.gebish.org/manual/current/navigator.html#accessing_tag_name_attributes_text_and_classes

People

  • Assignee:
    Marcin Erdmann
    Reporter:
    Matt Follett
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: