Geb
  1. Geb
  2. GEB-123

turn all statements in a waitFor block into assertions implicitly

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.7.0
    • Component/s: Core
    • Labels:
      None
    • Number of attachments :
      0

      Description

      We currently provide a waitFor() method that accepts a closure and executes the closure at a given interval for a number of seconds, waiting for it to pass (i.e. return a true value and not throw an exception.

      The problem with this is that if the closure doesn't pass we don't have any information on why in the exception. What would be nice is to turn each "statement" into an implicit assertion (i.e. add "assert" to the statement) so we can get nice output.

      Relavant Geb feature: http://www.gebish.org/manual/current/javascript.html#waiting

        Issue Links

          Activity

          Luke Daley made changes -
          Field Original Value New Value
          Fix Version/s 0.7.0 [ 17291 ]
          Marcin Erdmann made changes -
          Assignee Luke Daley [ ldaley ] Marcin Erdmann [ erdi ]
          Marcin Erdmann made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          Marcin Erdmann made changes -
          Link This issue relates to GEB-168 [ GEB-168 ]
          Marcin Erdmann made changes -
          Comment [ Also add compilation warnings if someone uses an explicit return statement in a waitFor closure ]
          Marcin Erdmann made changes -
          Status In Progress [ 3 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Marcin Erdmann made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Marcin Erdmann
              Reporter:
              Luke Daley
            • Votes:
              2 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: