Issue Details (XML | Word | Printable)

Key: FEST-85
Type: Improvement Improvement
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Alex Ruiz
Reporter: Andriy Tsykholyas
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
FEST

JTableFixture should have a possibility to provide a custom subclass of JTableDriver.

Created: 06/Mar/09 04:47 AM   Updated: 12/Mar/09 01:32 AM   Resolved: 12/Mar/09 01:32 AM
Return to search
Component/s: Swing
Affects Version/s: FEST-Swing 1.1
Fix Version/s: FEST-Swing 1.2a1

Time Tracking:
Not Specified

File Attachments: 1. File JTableFixture.diff (1.0 kB)
2. Java Source File JTableFixture.java (29 kB)
3. Zip Archive mylyn-context.zip (67 kB)


Patch Submitted: Yes


 Description  « Hide

The application I'm testing with FEST has a heavily customized JTable. Some JTableDriver methods don't operate fine on this table. So, I'd like to have the ability to provide a custom subclass of JTableDriver to JTableFixture (or to subclass of JTableFixture). Currently this is not possible.

Here is my proposal:
1) Make JTableFixture.createDriver() protected and give it a return value of type JTableDriver. It shoudl not call updateDriver(), but simply return JTableDriver.
2) Make JTableFixture constructors to call updateDriver() and pass to it the result of createDriver() invocation.

This approach is similar to the one adopted by swing. It should not break anything inside FEST, but allows to provide custom subclass of JTableDriver to custom JTableFixture.

I'm attaching modified JTableFixture and a diff file. Not sure the latter is needed but is shows my modifications



Alex Ruiz made changes - 06/Mar/09 08:34 AM
Field Original Value New Value
Assignee Alex Ruiz [ alexruiz ]
Fix Version/s Cairo [ 15055 ]
Patch Submitted [Yes]
Alex Ruiz made changes - 07/Mar/09 01:44 AM
Status Open [ 1 ] In Progress [ 3 ]
Alex Ruiz made changes - 12/Mar/09 01:32 AM
Resolution Fixed [ 1 ]
Status In Progress [ 3 ] Resolved [ 5 ]
Alex Ruiz made changes - 12/Mar/09 01:32 AM
Attachment mylyn-context.zip [ 40582 ]