FEST

Assert.isIn() and isNotIn() should take Iterable<?>

Details

  • Type: Improvement Improvement
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: FEST-Assert 2.0
  • Fix Version/s: FEST-Assert 2.0
  • Component/s: Assert
  • Labels:
  • Number of attachments :
    0

Description

Iterable is a more general interface and i think it makes sense to use it here (and maybe other places). For example it can be usefull when working with Spring DAOs - take a look at [1].

[1]: https://github.com/SpringSource/spring-data-commons/blob/master/spring-data-commons-core/src/main/java/org/springframework/data/repository/CrudRepository.java

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Joel Costigliola added a comment -

I agree with that, we have "upgraded" collection assertions to Iterable assertions (thanks to Maciej Jaśkowski), we should also migrated isIn and isNotIn.

You can try to fix this issue, it should not be too complicated (I'll do it otherwise but I don't have much time these days).
We are on github here : https://github.com/alexruiz/fest-assert-2.x
And the contribution guide is here : https://github.com/alexruiz/fest-assert-2.x/wiki/Contributor-guidelines.

Cheers,

Joel

Show
Joel Costigliola added a comment - I agree with that, we have "upgraded" collection assertions to Iterable assertions (thanks to Maciej Jaśkowski), we should also migrated isIn and isNotIn. You can try to fix this issue, it should not be too complicated (I'll do it otherwise but I don't have much time these days). We are on github here : https://github.com/alexruiz/fest-assert-2.x And the contribution guide is here : https://github.com/alexruiz/fest-assert-2.x/wiki/Contributor-guidelines . Cheers, Joel
Joel Costigliola made changes -
Field Original Value New Value
Fix Version/s FEST-Assert 2.0 [ 15576 ]
Hide
Permalink
Nicolas FRANCOIS added a comment -

I did it :

https://github.com/alexruiz/fest-assert-2.x/pull/15

Show
Nicolas FRANCOIS added a comment - I did it : https://github.com/alexruiz/fest-assert-2.x/pull/15
Hide
Permalink
Joel Costigliola added a comment -

Thanks Nicolas !

Show
Joel Costigliola added a comment - Thanks Nicolas !
Joel Costigliola made changes -
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]

People

  • Assignee:
    Unassigned
    Reporter:
    Mikhail Mazursky
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: