FEST

equals not overrided

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: FEST-Assert 2.0M1
  • Fix Version/s: FEST-Assert 2.0M1
  • Component/s: Assert
  • Labels:
    None
  • Number of attachments :
    0

Description

FestAssert 1.4 throw a unsupported exception but not 2.0

A beginner can write (it also happens when I am distracted) :

assertThat("aString").equals("anotherString");

This test should fail, but not.
Maybe an oversight ?

I've implemented by copying it from 1.4 sources.
it was also possible to delegate to objets by example. I more close to general design but a little bit idiot just for throwing a exception.
Hascode still 1 ?

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Joel Costigliola added a comment -

I think we have have forgotten to port that feature in 2.0, thanks for spotting that.
I agree there is no need to delegate to Objects, let's keep it simple.

Concerning the hashCode, 1 is not an efficient hash code but at least it is not wrong.

I will integrate your pull request probably today or tomorrow.

Show
Joel Costigliola added a comment - I think we have have forgotten to port that feature in 2.0, thanks for spotting that. I agree there is no need to delegate to Objects, let's keep it simple. Concerning the hashCode, 1 is not an efficient hash code but at least it is not wrong. I will integrate your pull request probably today or tomorrow.
Hide
Permalink
Joel Costigliola added a comment -

Thanks Nicolas.

Show
Joel Costigliola added a comment - Thanks Nicolas.

People

  • Assignee:
    Joel Costigliola
    Reporter:
    Nicolas FRANCOIS
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: