FEST

Improve how we fail a unit test expecting an AssertionError to be thrown

Details

  • Type: Improvement Improvement
  • Status: Resolved Resolved
  • Priority: Trivial Trivial
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: FEST-Assert 2.0M1
  • Component/s: Assert
  • Labels:
    None
  • Number of attachments :
    0

Description

Example, in code ...

  @Test public void should_fail_if_object_is_not_null() {
    AssertionInfo info = someInfo();
    Object actual = new Object();
    try {
      objects.assertNull(info, actual);
    } catch (AssertionError e) {
      verify(failures).failure(info, shouldBeEqual(actual, null));
      return;
    }
    throw expectedAssertionErrorNotThrown();
  }

... we can get rid of throw in the last line and call use Assert.fail("Assertion error expected") that is encapsulated in a method failBecauseExpectedAssertionErrorWasNotThrown() for better readability

  @Test public void should_fail_if_object_is_not_null() {
    AssertionInfo info = someInfo();
    Object actual = new Object();
    try {
      objects.assertNull(info, actual);
    } catch (AssertionError e) {
      verify(failures).failure(info, shouldBeEqual(actual, null));
      return;
    }
    failBecauseExpectedAssertionErrorWasNotThrown(); // simply calls Assert.fail("Assertion error expected");
  }

Activity

There are no comments yet on this issue.

People

  • Assignee:
    Joel Costigliola
    Reporter:
    Joel Costigliola
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: