| Key: |
FEST-37
|
| Type: |
Improvement
|
| Status: |
Resolved
|
| Resolution: |
Fixed
|
| Priority: |
Trivial
|
| Assignee: |
Alex Ruiz
|
| Reporter: |
Ondrej Medek
|
| Votes: |
0
|
| Watchers: |
0
|
|
If you were logged in you would be able to see more operations.
|
|
|
Classes in org.fest.swing.core.matcher.* should be marked as final (if they are not assumed to be extendable), or their properties should be protected, not private (so they can be extended).
|
|
Description
|
Classes in org.fest.swing.core.matcher.* should be marked as final (if they are not assumed to be extendable), or their properties should be protected, not private (so they can be extended). |
Show » |
Sort Order:
made changes - 05/Mar/09 12:15 PM
| Field |
Original Value |
New Value |
|
Assignee
|
|
Alex Ruiz
[ alexruiz
]
|
|
Affects Version/s
|
|
Tirane
[ 15051
]
|
|
Fix Version/s
|
|
Cairo
[ 15055
]
|
|
Issue Type
|
Bug
[ 1
]
|
Improvement
[ 4
]
|
made changes - 28/Apr/09 12:07 PM
|
Status
|
Open
[ 1
]
|
In Progress
[ 3
]
|
made changes - 28/Apr/09 07:19 PM
|
Resolution
|
|
Fixed
[ 1
]
|
|
Status
|
In Progress
[ 3
]
|
Resolved
[ 5
]
|
|
Are classes in org.fest.swing.core.matcher.* final? 
My original intention was to allow extension of the matchers. After giving it a second thought, I decided to mark them as final. The reason is the lack of static-typing checks for their constructors. They take Objects as arguments, and in many cases it should be Strings (e.g. name, title.) The reason for using Objects is to allow the use of ANY. If subclasses send the wrong argument, the matching can fail at runtime, instead of having the compiler to check for these errors. The type checking is perform in the static factory methods though.