FEST

allow setting of memoryMaxSize

Details

  • Patch Submitted:
    Yes
  • Number of attachments :
    0

Description

It is currently not possible to compile a large project using the maven plugin since the maximum heap size can not be set.

Please add an option to set it. A trivial implementation looks like this:

Index: src/main/java/org/fest/javafx/maven/JavaFxcSetup.java
===================================================================
--- src/main/java/org/fest/javafx/maven/JavaFxcSetup.java	(Revision 1105)
+++ src/main/java/org/fest/javafx/maven/JavaFxcSetup.java	(Arbeitskopie)
@@ -49,6 +49,7 @@
     javaFxc.setSource(javaFxcMojo.source);
     javaFxc.setTarget(javaFxcMojo.target);
     javaFxc.setVerbose(javaFxcMojo.verbose);
+    javaFxc.setMemoryMaximumSize(javaFxcMojo.memoryMaximumSize);
     if ( javaFxcMojo.unchecked ) {
       javaFxc.createCompilerArg().setLine( "-Xlint:unchecked" );
     }
Index: src/main/java/org/fest/javafx/maven/AbstractJavaFxcMojo.java
===================================================================
--- src/main/java/org/fest/javafx/maven/AbstractJavaFxcMojo.java	(Revision 1105)
+++ src/main/java/org/fest/javafx/maven/AbstractJavaFxcMojo.java	(Arbeitskopie)
@@ -69,6 +69,12 @@
    */
   @VisibleForTesting String encoding;
 
+/**
+   * The maximum memory size.
+   * @parameter expression="${javafx.compiler.memorymaximumsize}" default-value="256m"
+   */
+  @VisibleForTesting String memoryMaximumSize;
+
   /**
    * Indicates whether the build will continue even if there are compilation errors; defaults to <code>true</code>.
    * @parameter expression="${javafx.compiler.failOnError}" default-value="true"

Activity

There are no comments yet on this issue.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: