FEST

Incorrect generic declaration in ObjectAssert satisfies doesNotSatisfy methods

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: FEST-Assert 1.3
  • Fix Version/s: FEST-Assert 2.0
  • Component/s: Assert
  • Labels:
    None
  • Number of attachments :
    0

Description

Method
org.fest.assertions.ObjectAssert.satisfies(Condition<Object>) and
org.fest.assertions.ObjectAssert.doesNotSatisfy(Condition<Object>)
declarations must be changed to
org.fest.assertions.ObjectAssert.satisfies(Condition<?>) and
org.fest.assertions.ObjectAssert.doesNotSatisfy(Condition<?>)

At present, there is only way to use this two methods is to implement Condition<Object> and make explicit type cast from Object to user type. It's inconvenient for common use.

Activity

Ascending order - Click to sort in descending order
Alex Ruiz made changes -
Field Original Value New Value
Assignee Yvonne Wang [ wanghy ]
Fix Version/s FEST-Assert 1.3 [ 15940 ]
Yvonne Wang made changes -
Status Open [ 1 ] In Progress [ 3 ]
Hide
Permalink
Alex Ruiz added a comment -

We tried to fix this issue, but it requires more thought than we thought. It is not just a simple replace of <Object> to <?>, due to the current object hierarchy in the project. We'll revisit this issue for FEST-Assert 2.0.

Show
Alex Ruiz added a comment - We tried to fix this issue, but it requires more thought than we thought. It is not just a simple replace of <Object> to <?>, due to the current object hierarchy in the project. We'll revisit this issue for FEST-Assert 2.0.
Alex Ruiz made changes -
Fix Version/s FEST-Assert 2.0 [ 15576 ]
Fix Version/s FEST-Assert 1.3 [ 15940 ]
Joel Costigliola made changes -
Assignee Yvonne Wang [ wanghy ] Joel Costigliola [ jocosti ]
Hide
Permalink
Joel Costigliola added a comment - - edited

Fixed in 2.0M4

Note that satisfies(Condition) has been replaced by is(Condition) or has(Condition), e.g. : 

assertThat("Yoda").is(jedi);
assertThat(noah).has(doubleDoubleStats);
assertThat(durant).doesNotHave(doubleDoubleStats);
try {
   assertThat(rose).has(doubleDoubleStats);
} catch (AssertionError e) {
   assertThat(e).hasMessage("expecting:<Player[Derrick Rose, team=Chicago Bulls]> to have:<double double stats>");
}

More examples in fest-example project and more precisely UsingConditionExamples.java

Show
Joel Costigliola added a comment - - edited Fixed in 2.0M4 Note that satisfies(Condition) has been replaced by is(Condition) or has(Condition), e.g. : assertThat( "Yoda" ).is(jedi); assertThat(noah).has(doubleDoubleStats); assertThat(durant).doesNotHave(doubleDoubleStats); try { assertThat(rose).has(doubleDoubleStats); } catch (AssertionError e) { assertThat(e).hasMessage( "expecting:<Player[Derrick Rose, team=Chicago Bulls]> to have:< double double stats>" ); } More examples in fest-example project and more precisely UsingConditionExamples.java
Joel Costigliola made changes -
Status In Progress [ 3 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]

People

  • Assignee:
    Joel Costigliola
    Reporter:
    Sergey Parilin
Vote (1)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: