FEST
  1. FEST
  2. FEST-218

Inconsistency in parameter names in assertions

    Details

    • Type: Bug Bug
    • Status: Resolved Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: FEST-Assert 1.1
    • Fix Version/s: FEST-Assert 1.2
    • Component/s: Assert
    • Labels:
      None
    • Number of attachments :
      0

      Description

      From Ted:

      I've noticed that we're using different parameter variable names in the assert class methods, sometimes we us "expected", other times "other" and occasionally "obj".

      public IntAssert isEqualTo(int expected) {
      
      public IntAssert isNotEqualTo(int value) {
      
      protected final void assertNotEqualTo(T obj) {
      

      How important is it to be consistent here? For asserts that are testing for equality or something similar, "expected" makes sense, but for isNotEqualTo() (for example), "other" is used. Not sure about "obj" (probably should be "other"). For numeric asserts, "value" is used instead of "other". Seems to me we could just use "other".

        Activity

        There are no comments yet on this issue.

          People

          • Assignee:
            Unassigned
            Reporter:
            Alex Ruiz
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: