Issue Details (XML | Word | Printable)

Key: FEST-198
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Ansgar Konermann
Reporter: Ansgar Konermann
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
FEST

Fix ImageAssert.read to compile successfully against Java 1.5

Created: 21/Jul/09 02:44 PM   Updated: 22/Jul/09 02:59 PM   Resolved: 22/Jul/09 02:55 PM
Return to search
Component/s: Assert
Affects Version/s: FEST-Assert 1.1
Fix Version/s: FEST-Assert 1.2

Time Tracking:
Original Estimate: 15 minutes
Original Estimate - 15 minutes
Remaining Estimate: 0 minutes
Remaining Estimate - 0 minutes
Time Spent: 30 minutes
Time Spent - 30 minutes


 Description  « Hide

The current sourcecode uses a IOException constructor which is only available in Java 1.6 and later:

new IOException(concat("Unable to read image from file ", quote(imageFilePath)), e);

This code won't compile against Java 1.5, which is the Java version we chose as our source and target platform in the parent pom.xml

Fix this by not catching the IOException. Instead, simply let it fly "as is".



Ansgar Konermann made changes - 21/Jul/09 02:56 PM
Field Original Value New Value
Status Open [ 1 ] In Progress [ 3 ]
Ansgar Konermann made changes - 21/Jul/09 02:56 PM
Status In Progress [ 3 ] Open [ 1 ]
Ansgar Konermann added a comment - 21/Jul/09 02:57 PM - edited

Fixed in SVN revision 332. Needs assignment to one of the upcoming releases.


Ansgar Konermann made changes - 21/Jul/09 02:57 PM
Resolution Fixed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]
Ansgar Konermann made changes - 21/Jul/09 02:58 PM
Status Resolved [ 5 ] Closed [ 6 ]
Ansgar Konermann made changes - 22/Jul/09 02:33 PM
Assignee Ansgar Konermann [ konermann ] Alex Ruiz [ alexruiz ]
Status Closed [ 6 ] Reopened [ 4 ]
Resolution Fixed [ 1 ]
Ansgar Konermann made changes - 22/Jul/09 02:35 PM
Resolution Fixed [ 1 ]
Status Reopened [ 4 ] Resolved [ 5 ]
Ansgar Konermann made changes - 22/Jul/09 02:40 PM
Status Resolved [ 5 ] Reopened [ 4 ]
Resolution Fixed [ 1 ]
Ansgar Konermann made changes - 22/Jul/09 02:40 PM
Comment [ Please assign fix to one of the upcoming releases. ]
Alex Ruiz made changes - 22/Jul/09 02:50 PM
Affects Version/s FEST-Swing 1.2a2 [ 15264 ]
Affects Version/s FEST-Assert 1.1 [ 15053 ]
Fix Version/s FEST-Assert 1.2a1 [ 15402 ]
Alex Ruiz made changes - 22/Jul/09 02:50 PM
Assignee Alex Ruiz [ alexruiz ] Ansgar Konermann [ konermann ]
Ansgar Konermann made changes - 22/Jul/09 02:53 PM
Comment [ Test shouldReturnNullImageFileIfIOExceptionThrown fails. Going to fix this first. ]
Ansgar Konermann made changes - 22/Jul/09 02:54 PM
Status Reopened [ 4 ] In Progress [ 3 ]
Ansgar Konermann made changes - 22/Jul/09 02:54 PM
Status In Progress [ 3 ] Open [ 1 ]
Ansgar Konermann made changes - 22/Jul/09 02:55 PM
Resolution Fixed [ 1 ]
Fix Version/s FEST-Assert 1.2a1 [ 15402 ]
Status Open [ 1 ] Resolved [ 5 ]
Ansgar Konermann made changes - 22/Jul/09 02:55 PM
Assignee Ansgar Konermann [ konermann ] Alex Ruiz [ alexruiz ]
Ansgar Konermann logged work - 22/Jul/09 02:56 PM
Time Worked: 30 minutes
<No comment>
Ansgar Konermann made changes - 22/Jul/09 02:56 PM
Time Spent 30 minutes [ 1800 ]
Remaining Estimate 15 minutes [ 900 ] 0 minutes [ 0 ]
Alex Ruiz made changes - 22/Jul/09 02:59 PM
Assignee Alex Ruiz [ alexruiz ] Ansgar Konermann [ konermann ]
Alex Ruiz made changes - 22/Jul/09 02:59 PM
Fix Version/s FEST-Assert 1.2a1 [ 15402 ]