Enunciate

JSON Overlay types should implement interfaces of model classes

Details

  • Type: Improvement Improvement
  • Status: Open Open
  • Priority: Critical Critical
  • Resolution: Unresolved
  • Affects Version/s: 1.21.1
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    0

Description

Since GWT 2.0 JSON Overlay types can implement an interface as long as no 2 overlay types implement the same interface. If the model classes we're building JSON Overlay types for implement an interface, the JSON Overlay type should implement this interface as well. This will allow the code which deals with them to be more easily tested without resorting to slow GwtTestCase tests which run the server.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jason Carreira added a comment -

The generated model classes for GWT RPC should also implement these interfaces, then the JSON Overlay facade from ENUNCIATE-533 could implement the same Async interface as the remote handle to the GWT RPC service.

Show
Jason Carreira added a comment - The generated model classes for GWT RPC should also implement these interfaces, then the JSON Overlay facade from ENUNCIATE-533 could implement the same Async interface as the remote handle to the GWT RPC service.
Hide
Permalink
Jason Carreira added a comment -

As I'm implementing this manually, implementing the interfaces from the model doesn't get you anything. The JSON overlay types should pull out an interface per model object all of the interfaces should refer to other interfaces, with generics to allow the overlay implementations to refer to other overlay implementations as needed. This will allow you to build a non-JSON implementation of the interfaces for unit tests that don't run in GwtTestCase.

Show
Jason Carreira added a comment - As I'm implementing this manually, implementing the interfaces from the model doesn't get you anything. The JSON overlay types should pull out an interface per model object all of the interfaces should refer to other interfaces, with generics to allow the overlay implementations to refer to other overlay implementations as needed. This will allow you to build a non-JSON implementation of the interfaces for unit tests that don't run in GwtTestCase.
Hide
Permalink
Ryan Heaton added a comment -

I've gotta push this off, as the scope is too big to fit into 1.21.

Show
Ryan Heaton added a comment - I've gotta push this off, as the scope is too big to fit into 1.21.

People

  • Assignee:
    Ryan Heaton
    Reporter:
    Jason Carreira
Vote (0)
Watch (0)

Dates

  • Created:
    Updated: