EasyMock

EasyMockProperties use of System properties isn't thread safe

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 3.1
  • Fix Version/s: 3.2
  • Component/s: Core
  • Labels:
    None
  • Testcase included:
    yes
  • Patch Submitted:
    Yes
  • Number of attachments :
    4

Description

EasyMockProperties use System Properties keySet() method which can lead to exceptions in the case simultaneous change of the System Properties from another thread.
This happens a lot in our build once we enable parallel unit test running.

Attached is a fix (full_patch.txt). I've also attached the 3 intermediate patches that I've used to refactor the code, write the test reproducing the issue and fix it.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jerome Lacoste added a comment -

Proper version of the fix.

Show
Jerome Lacoste added a comment - Proper version of the fix.
Hide
Permalink
Henri Tremblay added a comment -

Just a question. Why are the system properties changing in your parallel build? They are modified by the tests?

Show
Henri Tremblay added a comment - Just a question. Why are the system properties changing in your parallel build? They are modified by the tests?
Hide
Permalink
Henri Tremblay added a comment -

I did simpler than the patch. I'm just looking in the system properties for the three properties I know I'm using. I'll probably discard the system property feature anyway.

Show
Henri Tremblay added a comment - I did simpler than the patch. I'm just looking in the system properties for the three properties I know I'm using. I'll probably discard the system property feature anyway.

People

  • Assignee:
    Henri Tremblay
    Reporter:
    Jerome Lacoste
Vote (1)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: