drools-legacy

IO and SMF DroolsTestCase classes out of synch with Core version

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: future
  • Component/s: build
  • Labels:
    None
  • Number of attachments :
    1

Description

The source for the org.drools.DroolsTestCase class appears in the drools-core, drools-io, and drools-smf sub-directories. The one in drools-core was recently updated, but the duplicates in drools-io and drools-smf were not updated to match.

This causes the Ant build (via build.xml) to fail since it relies on copying the source from all the sub-directories into one location for compilation. The out-dated versions of DroolsTestCase are overwriting the updated version and this causes the Ant build to fail.

Someone should either update the two other classes to be like the first, or remove this duplicate code altogether.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Andy Barnett added a comment -

Attached is a patch which copies the updates made to the core version of the DroolsTestCase class over to the IO and SMF versions.

Show
Andy Barnett added a comment - Attached is a patch which copies the updates made to the core version of the DroolsTestCase class over to the IO and SMF versions.
Hide
Permalink
N. Alex Rupp added a comment -

Why do we have this duplicate testing code in here in the first place? Is it for code coverage reasons? I can dup the test class over to SMF and IO (sorry for the trouble, Andy--I'll make sure to include the ant stuff in our damagecontrol check in the future)

Show
N. Alex Rupp added a comment - Why do we have this duplicate testing code in here in the first place? Is it for code coverage reasons? I can dup the test class over to SMF and IO (sorry for the trouble, Andy--I'll make sure to include the ant stuff in our damagecontrol check in the future)
Hide
Permalink
Andy Barnett added a comment -

I think the duplicate testing code is an artifact of when the drools source was split into nine separate sub-projects. I have identified four test classes that can be found in two or more of the sub-project source trees: org.drools.MockObjectType, org.drools.spi.MockTuple, org.drools.MockWorkingMemory, org.drools.DroolsTestCase.

I agree that this duplicate code should be eliminated. One way to remove the duplication may be to create a 10th sub-project called drools-test and consolidate all the test code into that new sub-project.

Show
Andy Barnett added a comment - I think the duplicate testing code is an artifact of when the drools source was split into nine separate sub-projects. I have identified four test classes that can be found in two or more of the sub-project source trees: org.drools.MockObjectType, org.drools.spi.MockTuple, org.drools.MockWorkingMemory, org.drools.DroolsTestCase. I agree that this duplicate code should be eliminated. One way to remove the duplication may be to create a 10th sub-project called drools-test and consolidate all the test code into that new sub-project.
Hide
Permalink
Andy Barnett added a comment -

Mark Proctor has suggested: "the only asnwer is to split drools-core into drools-interface drools-test and drools-core"

Show
Andy Barnett added a comment - Mark Proctor has suggested: "the only asnwer is to split drools-core into drools-interface drools-test and drools-core"

People

  • Assignee:
    Unassigned
    Reporter:
    Andy Barnett
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:

Time Tracking

Estimated:
Not Specified
Original Estimate - Not Specified
Remaining:
Not Specified
Remaining Estimate - Not Specified
Logged:
1h
Time Spent - 1 hour