Maven Doxia Tools

Separate inheritance and interpolation

Details

  • Type: Improvement Improvement
  • Status: Reopened Reopened
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: doxia-integration-tools-1.4
  • Fix Version/s: None
  • Component/s: Doxia Integration Tools
  • Labels:
    None
  • Number of attachments :
    0

Description

The implementation uses recursion to get an inherited model of the site.xml, but every step does the interpolation too.
So if the parent site.xml contains something like ${project.name}, its value will be an ancestor project name, often an unexpected value.
By moving the interpolation from the recursive method to the method-caller you will get the name of the active project.

Issue Links

is depended upon by

Bug - A problem which impairs or prevents the functions of the product. MSITE-135 inherited site.xml files are interpolated with the originating project's model values and not the consumer project's values

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Robert Scholte added a comment -

Fixed in rev. 1214470

Show
Robert Scholte added a comment - Fixed in rev. 1214470
Hide
Permalink
Robert Scholte added a comment -

The IT of MSITE-312 fails due to this modification. It seems that the site.xml should be partially interpolated during recursion.

Show
Robert Scholte added a comment - The IT of MSITE-312 fails due to this modification. It seems that the site.xml should be partially interpolated during recursion.
Hide
Permalink
Dennis Lundberg added a comment -

Robert,

What should we do about this issue?
I'd like to release Site Plugin 3.1 soon. Perhaps we don't need to update Site Plugin to use version 1.5 of doxia-integration-tools yet. In that case we can just leave this issue open a while longer.

Show
Dennis Lundberg added a comment - Robert, What should we do about this issue? I'd like to release Site Plugin 3.1 soon. Perhaps we don't need to update Site Plugin to use version 1.5 of doxia-integration-tools yet. In that case we can just leave this issue open a while longer.
Hide
Permalink
Robert Scholte added a comment -

Dennis,

I've reverted this change already due to the failing IT. The xml contains three types of data: static, inheritable and extendable. We need find to find a way of smart parsing to define which xml-sections are what kind of data. It's less straightforward as I hoped.
I'd suggest to leave this one open for now and pick it up later.

Show
Robert Scholte added a comment - Dennis, I've reverted this change already due to the failing IT. The xml contains three types of data: static, inheritable and extendable. We need find to find a way of smart parsing to define which xml-sections are what kind of data. It's less straightforward as I hoped. I'd suggest to leave this one open for now and pick it up later.
Hide
Permalink
Dennis Lundberg added a comment -

Removing this from the 1.5 release.

Show
Dennis Lundberg added a comment - Removing this from the 1.5 release.

People

  • Assignee:
    Robert Scholte
    Reporter:
    Robert Scholte
Vote (0)
Watch (2)

Dates

  • Created:
    Updated: