Maven Doxia Sitetools
  1. Maven Doxia Sitetools
  2. DOXIASITETOOLS-59

Using a relative path to an image in a <poweredBy><logo> generates a wrong "src" value for HTML <img> tag

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.2
    • Fix Version/s: 1.3
    • Component/s: Site renderer
    • Labels:
      None
    • Patch Submitted:
      Yes
    • Number of attachments :
      2

      Description

      This happens only when a <bannerLeft> or <bannerRight> is also used.
      Then the logo image becomes the same than the banner image.
      (see attached site.xml)

      This problem comes from default-site.vm in poweredByLOgo macro:
      in calculation of relative path of $img code is following
      #set ( $img = $src.replaceAll( '
      ', '/' ) )
      But should be following
      #set ( $img = $img.replaceAll( '
      ', '/' ) )

      Please see proposed patch in attachment.

      1. default-site.patch
        0.6 kB
        Juien Enoch
      2. site.vm
        20 kB
        Juien Enoch

        Issue Links

          Activity

          Hide
          Lukas Theussl added a comment -

          Funny, I just bumped into this myself today I'll fix it over the weekend.

          Show
          Lukas Theussl added a comment - Funny, I just bumped into this myself today I'll fix it over the weekend.
          Hide
          Lukas Theussl added a comment -

          Fixed in r1100544. Thanks!

          Show
          Lukas Theussl added a comment - Fixed in r1100544 . Thanks!

            People

            • Assignee:
              Lukas Theussl
              Reporter:
              Juien Enoch
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: