Maven Doxia Sitetools

SiteRender generates double anchors for section headers

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.1.4
  • Fix Version/s: 1.2
  • Component/s: Site renderer
  • Labels:
    None
  • Testcase included:
    yes
  • Number of attachments :
    0

Description

The SiteRenderer adds anchors to section headers, even if they have already been added.

See http://jira.codehaus.org/browse/DOXIA-420 which has examples of double-anchors on the Maven site.

Issue Links

relates to

Bug - A problem which impairs or prevents the functions of the product. DOXIA-420 1.1 is not supposed to generate anchors for section titles, but it does

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
SebbASF added a comment -

It ought to be possible to suppress unwanted anchors. Doxia itself does not auto-generate them, so the SiteRenderer should be configurable too.

Since some people may be relying on the auto-generation, I think the behaviour should be changed as follows:

1) Don't generate a second anchor, ever.
2) Optionally, suppress generation of anchors for section headers.

Show
SebbASF added a comment - It ought to be possible to suppress unwanted anchors. Doxia itself does not auto-generate them, so the SiteRenderer should be configurable too. Since some people may be relying on the auto-generation, I think the behaviour should be changed as follows: 1) Don't generate a second anchor, ever. 2) Optionally, suppress generation of anchors for section headers.
Hide
Permalink
Lukas Theussl added a comment -

I think the main issue here is backward compatibility, there are zillions of pages still stemming from the doxia-1.0-beta days that expect this behavior, and changing this would lead to broken links everywhere. It's probably better to first deprecate it and log a warning, then remove it in doxia-1.2.

Show
Lukas Theussl added a comment - I think the main issue here is backward compatibility, there are zillions of pages still stemming from the doxia-1.0-beta days that expect this behavior, and changing this would lead to broken links everywhere. It's probably better to first deprecate it and log a warning, then remove it in doxia-1.2.
Hide
Permalink
sebbaz+ch added a comment -

Exactly, which is why I suggested making it optional not to generate anchors for section headers.

But generating double anchors for headers is always wrong, and should be fixed regardless.

Show
sebbaz+ch added a comment - Exactly, which is why I suggested making it optional not to generate anchors for section headers. But generating double anchors for headers is always wrong, and should be fixed regardless.
Hide
Permalink
Herve Boutemy added a comment -

fixed in r1087084

Show
Herve Boutemy added a comment - fixed in r1087084

People

  • Assignee:
    Herve Boutemy
    Reporter:
    SebbASF
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: